Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 888807

Summary: sys-apps/baselayout - /boot/.keep prevents systemd gpt-auto-generator from working
Product: Gentoo Linux Reporter: Mike Gilbert <floppym>
Component: Current packagesAssignee: William Hubbs <williamh>
Status: RESOLVED FIXED    
Severity: normal CC: base-system, systemd
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Mike Gilbert gentoo-dev 2022-12-28 21:45:15 UTC
systemd's gpt-auto-generator will create an automount unit to mount the ESP if /boot exists as an empty directory.

sys-apps/baselayout[build] creates /boot, and installs a .keep file there. The .keep file prevents gpt-auto-generator from working properly.

I don't see any reason for the .keep files when they are created in pkg_{setup,preinst,postinst}. I would suggest we simply drop them.
Comment 1 Mike Gilbert gentoo-dev 2022-12-28 21:49:13 UTC
systemd code for reference:

https://github.com/systemd/systemd/blob/v252/src/gpt-auto-generator/gpt-auto-generator.c#L234
Comment 2 Larry the Git Cow gentoo-dev 2023-01-25 21:23:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/baselayout.git/commit/?id=066c554b6c233ac2a99a5b7693eb67705b277a16

commit 066c554b6c233ac2a99a5b7693eb67705b277a16
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2023-01-25 21:21:30 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2023-01-25 21:22:03 +0000

    drop .keep files in layout target
    
    Bug: https://bugs.gentoo.org/888807
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 Makefile | 2 --
 1 file changed, 2 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2023-01-27 17:30:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8922ff37ff381fde642f486cd74922ec060c4a15

commit 8922ff37ff381fde642f486cd74922ec060c4a15
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2023-01-27 17:29:04 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2023-01-27 17:29:21 +0000

    sys-apps/baselayout: add 2.10
    
    Closes: https://bugs.gentoo.org/648880
    Closes: https://bugs.gentoo.org/853820
    Closes: https://bugs.gentoo.org/888807
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 sys-apps/baselayout/Manifest               |   1 +
 sys-apps/baselayout/baselayout-2.10.ebuild | 368 +++++++++++++++++++++++++++++
 2 files changed, 369 insertions(+)