Summary: | net-im/telegram-desktop-4.4.1 fails to build with Qt5 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Attila Tóth <atoth> |
Component: | Current packages | Assignee: | Esteve Varela Colominas <esteve.varela> |
Status: | RESOLVED INVALID | ||
Severity: | normal | CC: | proxy-maint |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/telegramdesktop/tdesktop/commit/5990b0fabf4c28e70955b4b52965609dc282a5fe | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Attila Tóth
2022-12-28 15:08:12 UTC
This patch solves the issue: https://github.com/telegramdesktop/tdesktop/commit/5990b0fabf4c28e70955b4b52965609dc282a5fe This was already solved by https://github.com/gentoo/gentoo/blob/master/net-im/telegram-desktop/files/tdesktop-4.3.4-qt5-incompatibility-2.patch This patch is being applied by telegram-desktop-4.4.1. The only way in which it could still fail is if the configure process is if you somehow enabled autoupdate? (In reply to Esteve Varela Colominas from comment #2) > This was already solved by > https://github.com/gentoo/gentoo/blob/master/net-im/telegram-desktop/files/ > tdesktop-4.3.4-qt5-incompatibility-2.patch > > This patch is being applied by telegram-desktop-4.4.1. The only way in which > it could still fail is if the configure process is if you somehow enabled > autoupdate? I'm not aware I would have enabled autoupdate in any way. The commit mentioned in my comment have been introduced 3 weeks ago and tagged for 4.4.2. I wonder why they come up with this if the patch in the tree should have solved the issue. At least it works for me. Doesn't look harmful. The patch in upstream is the result of me pointing the gentoo patch out on their issue tracker. When I made the gentoo patch I wasn't sure of how to fix it, but the chunk of code the error was in is an unreachable branch in the gentoo package, so I ifdef'd it out. Either way, the patch currently in gentoo works on my end, and I can't reproduce your issue. I've just checked and the patch applies correctly, so it shouldn't be hitting the line you're getting an error on at all. Please include the full build.log? Speaking of, the line number you're hitting the error on is a different number than it'd be if the patch was applied. Are you sure the patch is being applied, and if you are, can you share a full build log? (In reply to Esteve Varela Colominas from comment #6) > Speaking of, the line number you're hitting the error on is a different > number than it'd be if the patch was applied. Are you sure the patch is > being applied, and if you are, can you share a full build log? I was wrong, because it was telegram-desktop-4.3.4, not telegram-desktop-4.4.1. Sorry for the noise. |