Summary: | app-containers/skopeo-1.8.0: build failure with =sys-fs/btrfs-progs-6.1.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | William Hubbs <williamh> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | base-system, holger, leonchik1976, sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=889694 https://github.com/kdave/btrfs-progs/issues/566 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge-info.txt
app-containers:skopeo-1.8.0:20221226-230715.log.bz2 emerge-history.txt environment etc.clang.tar.bz2 etc.portage.tar.bz2 One-liner patch to vendor/github.com/containers/storage/drivers/btrfs/btrfs.go |
Description
Toralf Förster
2022-12-26 23:15:18 UTC
Created attachment 845067 [details]
emerge-info.txt
Created attachment 845069 [details]
app-containers:skopeo-1.8.0:20221226-230715.log.bz2
Created attachment 845071 [details]
emerge-history.txt
Created attachment 845073 [details]
environment
Created attachment 845075 [details]
etc.clang.tar.bz2
Created attachment 845077 [details]
etc.portage.tar.bz2
The file size of ./files/temp.tar.bz2 is too big (28M) for an upload. For about 8 weeks the link http://tinderbox.zwiebeltoralf.de:31560/17.1_desktop_gnome-j4-20221225-112401/var/tmp/tb/issues/20221226-230731-app-containers_skopeo-1.8.0/files/temp.tar.bz2 is valid. Got the same here with current app-containers/skopeo-1.10.0-r1 - same error: /usr/lib/go/pkg/tool/linux_amd64/compile -o $WORK/b490/_pkg_.a -trimpath "$WORK/b490=>" -p github.com/containers/storage/drivers/btrfs -lang=go1.16 -installsuffix shared -buildid Hi7wH1ZQmW-qJ5x1u6j3/Hi7wH1ZQmW-qJ5x1u6j3 -goversion go1.19.4 -shared -c=4 -nolocalimports -importcfg $WORK/b490/importcfg -pack $WORK/b490/_cgo_gotypes.go $WORK/b490/btrfs.cgo1.go $WORK/b490/version.cgo1.go $WORK/b490/_cgo_import.go # github.com/containers/storage/drivers/btrfs vendor/github.com/containers/storage/drivers/btrfs/btrfs.go:385:11: args.lim.max_referenced undefined (type _Ctype_struct_btrfs_qgroup_limit has no field or method max_referenced) make: *** [Makefile:142: bin/skopeo] Error 2 [31;01m*[0m ERROR: app-containers/skopeo-1.10.0-r1::gentoo failed (compile phase): [31;01m*[0m emake failed The error from Toralf's build.log is: # github.com/containers/storage/drivers/btrfs vendor/github.com/containers/storage/drivers/btrfs/btrfs.go:387:11: args.lim.max_referenced undefined (type _Ctype_struct_btrfs_qgroup_limit has no field or method max_referenced) (In reply to Bernd Feige from comment #8) > Got the same here with current app-containers/skopeo-1.10.0-r1 - same error: Which version of btrfs-progs? Created attachment 847188 [details, diff]
One-liner patch to vendor/github.com/containers/storage/drivers/btrfs/btrfs.go
The field in btrfs_qgroup_limit_item is called max_rfer, not max_referenced. Fixing this lets the module compile.
(In reply to Sam James from comment #9) > (In reply to Bernd Feige from comment #8) > > Got the same here with current app-containers/skopeo-1.10.0-r1 - same error: > > Which version of btrfs-progs? 6.0.2 here. (In reply to Bernd Feige from comment #10) > Created attachment 847188 [details, diff] [details, diff] > One-liner patch to > vendor/github.com/containers/storage/drivers/btrfs/btrfs.go > > The field in btrfs_qgroup_limit_item is called max_rfer, not max_referenced. > Fixing this lets the module compile. Note: Cf. https://btrfs.wiki.kernel.org/index.php/Data_Structures (In reply to Bernd Feige from comment #11) > (In reply to Sam James from comment #9) > > (In reply to Bernd Feige from comment #8) > > > Got the same here with current app-containers/skopeo-1.10.0-r1 - same error: > > > > Which version of btrfs-progs? > > 6.0.2 here. Oops, sorry, just upgraded to 6.1.1... (In reply to Bernd Feige from comment #13) > (In reply to Bernd Feige from comment #11) > > (In reply to Sam James from comment #9) > > > (In reply to Bernd Feige from comment #8) > > > > Got the same here with current app-containers/skopeo-1.10.0-r1 - same error: > > > > > > Which version of btrfs-progs? > > > > 6.0.2 here. > > Oops, sorry, just upgraded to 6.1.1... ... And confirmed that app-containers/skopeo compiles fine with sys-fs/btrfs-progs-6.0.2 but fails needing the patch with sys-fs/btrfs-progs-6.1.1 installed. (In reply to Sam James from comment #15) > https://github.com/kdave/btrfs-progs/commit/ > e78fe2d92e75ef6655341a5f498891c5b3091cb7 Is in 6.1.1 Right - but they failed to revert libbtrfs/ioctl.h which actually gets installed to /usr/include/btrfs/ioctl.h... Ah! FWIW 1.10.1-tr1 gives: /usr/lib/go/pkg/tool/linux_amd64/compile -o $WORK/b490/_pkg_.a -trimpath "$WORK/b490=>" -p github.com/containers/storage/drivers/btrfs -lang=go1.16 -installsuffix shared -buildid faqqzdiIndOkaXUeOyUy/faqqzdiIndOkaXUeOyUy -goversion go1.19.4 -shared -nolocalimports -importcfg $WORK/b490/importcfg -pack $WORK/b490/_cgo_gotypes.go $WORK/b490/btrfs.cgo1.go $WORK/b490/version.cgo1.go $WORK/b490/_cgo_import.go # github.com/containers/storage/drivers/btrfs vendor/github.com/containers/storage/drivers/btrfs/btrfs.go:385:11: args.lim.max_referenced undefined (type _Ctype_struct_btrfs_qgroup_limit has no field or method max_referenced) make: *** [Makefile:142: bin/skopeo] Error 2 * ERROR: app-containers/skopeo-1.10.0-r1::gentoo failed (install phase): * emake failed * * If you need support, post the output of `emerge --info '=app-containers/skopeo-1.10.0-r1::gentoo'`, As noted in https://github.com/kdave/btrfs-progs/issues/566 the patch https://github.com/kdave/btrfs-progs/commit/27bb4f6819df6ad7771e089e1fd3f1bd1163e437 to btrfs-progs fixes the issue. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=205c9c405c1182613231e3564c678fb4855ac308 commit 205c9c405c1182613231e3564c678fb4855ac308 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-01-05 00:27:31 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-01-05 00:27:31 +0000 sys-fs/btrfs-progs: fix installed headers Closes: https://bugs.gentoo.org/888579 Closes: https://bugs.gentoo.org/889694 Signed-off-by: Sam James <sam@gentoo.org> sys-fs/btrfs-progs/btrfs-progs-6.1.1-r1.ebuild | 154 +++++++++++++++++++++ .../files/btrfs-progs-6.1.1-ioctl-fix.patch | 87 ++++++++++++ 2 files changed, 241 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5da2202f319d7c3ab3db3beb831e65e11b155793 commit 5da2202f319d7c3ab3db3beb831e65e11b155793 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-01-05 00:41:55 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-01-05 00:41:55 +0000 profiles: mask =sys-fs/btrfs-progs-6.1.1 Bug: https://bugs.gentoo.org/889694 Bug: https://bugs.gentoo.org/888579 Signed-off-by: Sam James <sam@gentoo.org> profiles/package.mask | 4 ++++ 1 file changed, 4 insertions(+) *** Bug 888645 has been marked as a duplicate of this bug. *** |