Bug 887981

Summary:	dev-util/bpftool-6.7.6 adds -Werror flag on its own
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Jakov Smolić <jsmolic>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, holger, toralf
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/35515
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-22 14:54:40 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/bpftool-6.0.12 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-22 14:54:42 UTC

Created attachment 844725 [details]
build.log

build log and emerge --info

Comment 2 Holger Hoffstätte 2023-01-13 11:31:58 UTC

Unfortunately it seems that this is common for all kernel tools, they all have -Werror sprinkled all over the place, often multiple times.

Comment 3 Agostino Sarubbo gentoo-dev

2023-01-25 07:11:33 UTC

ci has reproduced this issue with version 6.1.7 - Updating summary.

Comment 4 Jakov Smolić archtester

2024-01-06 01:15:03 UTC

*** Bug 920814 has been marked as a duplicate of this bug. ***

Comment 5 Agostino Sarubbo gentoo-dev

2024-02-24 16:44:17 UTC

ci has reproduced this issue with version 6.7.6 - Updating summary.

Comment 6 Holger Hoffstätte 2024-02-24 18:40:30 UTC

This was easier than expected, so I made a PR for 6.6.x and 6.7.x.

Comment 7 Larry the Git Cow gentoo-dev

2024-02-24 19:25:05 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24220478c1224c5491223df28b8af6d58358d3e8

commit 24220478c1224c5491223df28b8af6d58358d3e8
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2024-02-24 18:22:02 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2024-02-24 19:24:51 +0000

    dev-util/bpftool: remove -Werror
    
    Closes: https://bugs.gentoo.org/887981
    
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 dev-util/bpftool/bpftool-6.6.8.ebuild | 3 +++
 dev-util/bpftool/bpftool-6.7.6.ebuild | 3 +++
 2 files changed, 6 insertions(+)