Bug 887657 – [guru] dev-util/DirectXShaderCompiler-1.7.2207-r1 adds -Werror flag on its own

• Product: GURU
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-12-21 10:12:12 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/DirectXShaderCompiler-1.7.2207-r1 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

[Comment 1 Agostino Sarubbo 2022-12-21 10:12:15 UTC]

Created attachment 844361 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Larry the Git Cow 2022-12-27 08:05:34 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=0f5dd926bfafab1c0271b9e1ca873acff230c26a

commit 0f5dd926bfafab1c0271b9e1ca873acff230c26a
Author:     Denis Reva <[e-mail]>
AuthorDate: 2022-12-21 15:17:41 +0000
Commit:     Denis Reva <[e-mail]>
CommitDate: 2022-12-21 15:17:41 +0000

    dev-util/DirectXShaderCompiler: Disabled adding -Werror by it's own
    
    Closes: https://bugs.gentoo.org/887657
    Signed-off-by: Denis Reva <[e-mail]>

 .../DirectXShaderCompiler/DirectXShaderCompiler-1.7.2207-r1.ebuild     | 3 +++
 1 file changed, 3 insertions(+)