Bug 88756 – php-4.3.11 does not compile with gcc 3.4.3 and USE="flash" enabled

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Christian Hartmann 2005-04-11 12:15:29 UTC]

php-4.3.11 does not compile with gcc 3.4.3 and USE="flash" enabled.

http://www.manucorp.com/archives/php-bugs/200504/msg00065.php

[Comment 1 Christian Hartmann 2005-04-11 12:16:28 UTC]

Created attachment 56014 [details, diff]
swf.c.patch

[Comment 2 Christian Hartmann 2005-04-11 12:23:31 UTC]

Same for mod_php-{4.3.11,4.3.11-r1}.

[Comment 3 Martin Holzer (RETIRED) 2005-04-17 14:39:22 UTC]

i could confirm this is working

Index: php-sapi.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/php-sapi.eclass,v
retrieving revision 1.57
diff -u -b -B -r1.57 php-sapi.eclass
--- php-sapi.eclass     10 Apr 2005 20:46:31 -0000      1.57
+++ php-sapi.eclass     17 Apr 2005 21:38:17 -0000
@@ -272,6 +272,8 @@
        [ "${PV//4.3.6}" != "${PV}" ] && EPATCH_OPTS="-d ${S} -p1" epatch ${DISTDIR}/php-4.3.6-pcrealloc.patch

        use hardenedphp && [ -n "$HARDENEDPHP_PATCH" ] && epatch ${DISTDIR}/${HARDENEDPHP_PATCH}
+
+       epatch ${FILESDIR}/flash.patch
 }

[Comment 4 Marcos González 2005-04-19 16:10:17 UTC]

It works for me too, both with mod_php and php.

[Comment 5 Jakub Moc (RETIRED) 2005-04-21 11:38:37 UTC]

*** Bug 89947 has been marked as a duplicate of this bug. ***

[Comment 6 Eric Herot 2005-04-21 12:40:15 UTC]

the swf.c patch seems to fix this problem for me.

[Comment 7 Alvin A ONeal Jr 2005-05-04 18:32:41 UTC]

And for those of you that don't know how to patch an ebuild (like me), here's what you do (your situation may vary slightly):

# emerge php
-- once everything is unpacked and starts to compile hit <ctrl>+z to stop (pause) it
-- use an editor to open the file
# vim /var/tmp/portage/php-4.3.11/work/php-4.3.11/ext/swf/swf.c

-- replace this line:
goto err;
-- with these lines:
#ifdef VIRTUAL_DIR
		free(na);
#endif
		return;
-- and delete these lines:
err:
#ifdef VIRTUAL_DIR
	free(na);
#endif

-- save and quit

# fg %1
-- and let it compile correctly. =)

[Comment 8 Robin Johnson 2005-05-04 18:47:09 UTC]

*** Bug 91047 has been marked as a duplicate of this bug. ***

[Comment 9 Sebastian Bergmann (RETIRED) 2005-05-06 02:45:43 UTC]

The patch is now applied to the PHP 4.3.11 ebuilds.