Bug 887451

Summary:	[guru] dev-libs/sirit-0_p20220725 adds -Werror flag on its own
Product:	GURU	Reporter:	Agostino Sarubbo <ago>
Component:	Package issues	Assignee:	Samuel Bauer <samuel.bauer>
Status:	CONFIRMED ---
Severity:	normal	CC:	guru-bugs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	785607
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-20 14:12:03 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/sirit-0_p20220725 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-20 14:12:05 UTC

Created attachment 844153 [details]
build.log

build log and emerge --info

Comment 2 Samuel Bauer 2022-12-21 18:48:26 UTC

As suggested by "ago" on irc :), I de-unbundled libfmt from yuzu.
I also found that sirit used by yuzu is now managed by yuzu-team. So I will not unbundle it anymore despite it is a submodule.
I think this issue can be closed as I will drop sirit dependency in next yuzu snapshot, and it may lead to dev-libs/sirit last rite from guru.

yuzu/citra devs are going too fast, they rush on new things, it is quite hard to maintain packages, and I will not spend any time on sirit right now.