Bug 887249

Summary:	net-misc/vmpsd-1.4: many warnings due to missing headers inclusions
Product:	Gentoo Linux	Reporter:	Jocelyn Mayer <l_indien>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED FIXED
Severity:	normal	CC:	l_indien
Priority:	Normal	Keywords:	PATCH, PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=883125 https://github.com/gentoo/gentoo/pull/40614
Whiteboard:	~arch only
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	Output from emerge --info =net-misc/vmpsd-1.4 Patch proposal to silent 'implicit declaration of functions' warnings

Description Jocelyn Mayer 2022-12-19 18:28:47 UTC

When merging vmpsd, one will get many warnings:
implicit declaration of function 'xxx'
incompatible implicit declaration of built-in function 'xxx'
This could potentially lead to bugs if the listed functions would be called with wrong types parameters, as the compiler cannot check them without a valid prototype and can be easily fixed by adding a few headers inclusions.
As upstream seems dead (CVS repository, last release in 2014), I'm not to post a request on sourceforge, at least for now.

Reproducible: Always

Steps to Reproduce:
1. Emerge vmpsd
2. Admire the build log

Actual Results:  
Many warnings for implicit declarations of functions.

Expected Results:  
No such warning

Comment 1 Jocelyn Mayer 2022-12-19 18:30:43 UTC

Created attachment 843871 [details]
Output from emerge --info =net-misc/vmpsd-1.4

Comment 2 Jocelyn Mayer 2022-12-19 18:31:26 UTC

Created attachment 843873 [details, diff]
Patch proposal to silent 'implicit declaration of functions' warnings

Comment 3 Sam James archtester

2022-12-21 19:16:03 UTC

I think this is pretty much a duplicate of bug 883125 which contains the same errors, but given this has a patch, I'll See Also it.

Comment 4 Jocelyn Mayer 2022-12-21 19:24:22 UTC

Ooops... Sorry...
I did not see the other submission with a search, I would have post the patch there...
I notice the "metabug" #870412 for further patches of the same kind.

Comment 5 Larry the Git Cow gentoo-dev

2025-02-24 21:29:29 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=776788dd9d8424922c9ad961dd24929819507b9f

commit 776788dd9d8424922c9ad961dd24929819507b9f
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-02-17 13:12:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-24 21:28:40 +0000

    net-misc/vmpsd: update EAPI 7 -> 8, port to C23
    
    Incorporates patch from the bugzilla and bugs that bitrotten since:
    more missing declarations, wrong declarations, missing includes.
    
    Closes: https://bugs.gentoo.org/887249
    Closes: https://bugs.gentoo.org/883125
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/40614
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/vmpsd/files/vmpsd-1.4-C23.patch           | 159 +++++++++++++++++++++
 .../vmpsd/files/vmpsd-1.4-missing-includes.patch   |  80 +++++++++++
 .../{vmpsd-1.4.ebuild => vmpsd-1.4-r1.ebuild}      |  14 +-
 3 files changed, 246 insertions(+), 7 deletions(-)