Bug 887113

Summary:	sys-firmware/atmel-firmware-1.3-r2 fails to compile (CLANG-STRICTER-SYSTEM): atmel_fwl.c:40:1: error: type specifier missing, defaults to int; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/31565
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-19 08:11:49 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-firmware/atmel-firmware-1.3-r2 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-19 08:11:51 UTC

Created attachment 843615 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2023-07-14 07:29:14 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b4e8a16d9eade4225d3a6d27736e715b96340b5

commit 1b4e8a16d9eade4225d3a6d27736e715b96340b5
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-06-21 15:57:16 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-07-14 07:29:02 +0000

    sys-firmware/atmel-firmware: Fix type specifier missing, defaults to int
    
    Closes: https://bugs.gentoo.org/887113
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/31565
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../atmel-firmware/atmel-firmware-1.3-r3.ebuild    | 60 ++++++++++++++++++++++
 .../files/atmel-firmware-1.3-clang-16-build.patch  | 13 +++++
 2 files changed, 73 insertions(+)