Bug 886460

Summary:	sci-libs/ogdi-4.1.0-r1 fails to compile (CLANG-STRICTER-SYSTEM): vpfprop.c:1474:27: error: incompatible integer to pointer conversion passing char to parameter of type char ; take the address with & [-Wint-conversion]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Science Related Packages <sci>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jy6x2b32pie9
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/36095
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-17 08:37:33 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/ogdi-4.1.0-r1 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-17 08:37:35 UTC

Created attachment 843188 [details]
build.log

build log and emerge --info

Comment 2 jy6x2b32pie9 2024-04-04 12:21:35 UTC

Upstream PR: https://github.com/libogdi/ogdi/pull/28

Comment 3 Larry the Git Cow gentoo-dev

2024-04-05 07:40:48 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f05911cd1a46ac7b974ddcd9d09fec1a911373ac

commit f05911cd1a46ac7b974ddcd9d09fec1a911373ac
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2024-04-04 12:12:37 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2024-04-05 07:39:34 +0000

    sci-libs/ogdi: Fix C99 errors
    
    Closes: https://bugs.gentoo.org/886460
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/36095
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 .../ogdi/files/ogdi-4.1.0-c99-conversions.patch     | 21 +++++++++++++++++++++
 sci-libs/ogdi/ogdi-4.1.0-r1.ebuild                  |  3 ++-
 2 files changed, 23 insertions(+), 1 deletion(-)