Bug 886177 – games-emulation/ppsspp-1.14 overwrites user's optimization (-O*)

• Product: Gentoo Linux
• Status: UNCONFIRMED ---

[Description Agostino Sarubbo 2022-12-15 21:15:36 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-emulation/ppsspp-1.14 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: ci)

NOTE:
unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.

[Comment 1 Agostino Sarubbo 2022-12-15 21:15:38 UTC]

Created attachment 842927 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Ionen Wolkens 2022-12-15 22:18:57 UTC]

This looks invalid to me, seems to be same -O fine?

And don't think this check is going to work for various reasons, sometimes overriding is wanted for certain files / packages because of known issues too.

[Comment 3 Maciej Barć 2022-12-15 22:24:42 UTC]

It compiles with -O2 as instructed by the CFLAGS, what is the error here?
Btw it compiles correctly with -O3 on my system.

[Comment 4 Ionen Wolkens 2022-12-15 22:55:52 UTC]

Well, actually it looks like it's forcing -O2 for 7 files, "-O2.*-O2", not that I think it's something worth fixing in general.

There are packages where that's intentional too (e.g. mkvtoolnix needs to force -O0 for one file to prevent near-hanging).

[Comment 5 Ionen Wolkens 2022-12-15 23:05:25 UTC]

(In reply to Ionen Wolkens from comment #4)
> Well, actually it looks like it's forcing -O2 for 7 files, "-O2.*-O2", not
> that I think it's something worth fixing in general.
Note I meant that more for when there's just a few compilation lines that do this, not when it overrides every files.