Bug 886137

Summary:	sci-electronics/gsmc-1.1-r2 fails to compile (CLANG-STRICTER-SYSTEM): autotune.c:82:7: error: call to undeclared function recalc; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	The Soldering-Iron Brotherhood <sci-electronics>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/31991
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-15 14:43:52 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-electronics/gsmc-1.1-r2 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-15 14:43:54 UTC

Created attachment 842877 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2023-07-23 01:52:24 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9469342c7d179f27f09bf03fc6bd85d62b408fa9

commit 9469342c7d179f27f09bf03fc6bd85d62b408fa9
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-07-21 07:32:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-23 01:49:50 +0000

    sci-electronics/gsmc: Fix call to undeclared function recalc
    
    Closes: https://bugs.gentoo.org/886137
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/31991
    Signed-off-by: Sam James <sam@gentoo.org>

 .../gsmc/files/gsmc-1.1-clang16-build-fix.patch    | 41 ++++++++++++++++++++++
 sci-electronics/gsmc/gsmc-1.1-r3.ebuild            | 38 ++++++++++++++++++++
 2 files changed, 79 insertions(+)