Bug 885573

Summary:	media-video/lxdvdrip-1.77-r1 fails to compile (CLANG-STRICTER-SYSTEM): systools.c:488:8: error: call to undeclared function ioctl; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/31916
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-12 12:04:06 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-video/lxdvdrip-1.77-r1 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-12 12:04:08 UTC

Created attachment 841937 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2023-08-22 07:45:46 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89b422287c081ac7b05c896db479dcee11e59abe

commit 89b422287c081ac7b05c896db479dcee11e59abe
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-07-16 18:32:33 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-08-22 07:35:54 +0000

    media-video/lxdvdrip: Fix call to undeclared function ioctl
    
    Closes: https://bugs.gentoo.org/885573
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/31916
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../files/lxdvdrip-1.77-clang-16-build.patch       | 38 ++++++++++++++++
 media-video/lxdvdrip/lxdvdrip-1.77-r2.ebuild       | 51 ++++++++++++++++++++++
 2 files changed, 89 insertions(+)