Summary: | rmutt-1.3.ebuild (New) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tyson Burghardt <tysonburghardt> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | asl, tomwij, tysonburghardt |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
rmutt-1.3.ebuild (New)
rmutt-1.4.0_alpha1.ebuild (New) rmutt-1.3.ebuild (Update) rmutt-1.4.0_alpha1.ebuild (Update) rmutt-1.3.ebuild (Update) rmutt-1.4.0_alpha1.ebuild (Update) |
Description
Tyson Burghardt
2005-04-09 17:57:36 UTC
Created attachment 55817 [details]
rmutt-1.3.ebuild (New)
Created attachment 55818 [details]
rmutt-1.4.0_alpha1.ebuild (New)
this is the current unstable version; compiles and runs fine;
Tyson, there are a couple of things you can do to improve your ebuilds. For starters, don't mkdir in src_install -- instead lookup the documentation for "dodir" and "bininto". They're better for gentoo-ifying your ebuilds. Also, in your sed expression in src_unpack, use a different delimiter than "/" for the portions of your sed. In other words try: sed -i "s:find:replace:" instead. Also, do you really need that sed? Does the Makefile not define DESTDIR or PREFIX or some such that you can override in src_install like: make DESTDIR=${D} install? Please re-open this bug when you've made those changes, and we'll see what we can do about getting this into portage. Comment on attachment 55817 [details] rmutt-1.3.ebuild (New) ><HTML><HEAD><STYLE>u { text-decoration:none!important; font-style:italic!important; }</STYLE></HEAD><BODY><PRE><SPAN># Copyright 1999-2004 Gentoo Foundation ># Distributed under the terms of the GNU General Public License v2 ># $Header: $ > >DESCRIPTION="A utility for generating random text from context-free grammars." >HOMEPAGE="<A href="http://www.schneertz.com/rmutt/">http://www.schneertz.com/rmutt/</A>" >SRC_URI="<A href="http://www.schneertz.com/rmutt/${P}.tar.gz">http://www.schneertz.com/rmutt/${P}.tar.gz</A>" > >LICENSE="CCPL-Attribution-2.0" >SLOT="0" >KEYWORDS="~x86" > >IUSE="" >DEPEND="" >S=${WORKDIR}/rmutt > >src_unpack() { > unpack ${A} > cd "${S}" >} > >src_compile() { > emake || die "Make failed" >} > >src_install() { > dobin rmutt > make install || die > dodoc TODO README SYNTAX >} > ></SPAN> Created attachment 55993 [details]
rmutt-1.3.ebuild (Update)
removed sed script and mkdirs, simplified binary installation
Created attachment 55994 [details]
rmutt-1.4.0_alpha1.ebuild (Update)
removed sed script and mkdirs; simplified binary installation
I have changed the scripts as per your guidelines. The original Makefile's installation procedure did a literal 'cp $(EXE) /usr/local/bin/$(EXE)'; i.e., no DESTDIR. However, since there's only one file, the binary rmutt to move, 'dobin rmutt' works fine for installation. Thank you for your input; these are my first ebuilds and I just sort of puzzled it out. Tyson, you did well for your first time out :) The only final thing (sorry!) is the src_unpack() functions are redundant now, so they can be removed. Created attachment 56010 [details]
rmutt-1.3.ebuild (Update)
removed redundant src_unpack function
Created attachment 56011 [details]
rmutt-1.4.0_alpha1.ebuild (Update)
removed redundant src_unpack function
There's always something. :-) I take it the src_compile function is not redundant, despite the fact that it's fairly generic? Will any action be taken on this? Cleaning out older open bugs. Bump, can a decision be made on this? Can be re-assigned to maintainer-wanted if you can't take it... I guess this one should be closed... $ mutt -v Mutt 1.5.24 (2015-08-30, Gentoo 1.5.24-r2) Wooops... Too much chocolate... Sorry about the noise :) |