Bug 884923 – games-util/dzip-2.9-r4 fails to compile (CLANG-STRICTER-SYSTEM): delete.c:21:22: error: incompatible function pointer types passing int (const uInt , const uInt ) (aka int (const unsigned int , const unsigned int )) to parameter of type __compar_fn_t (ak

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-12-09 08:06:02 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-util/dzip-2.9-r4 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-09 08:06:04 UTC]

Created attachment 841065 [details]
build.log

build log and emerge --info

[Comment 2 Larry the Git Cow 2023-06-19 20:42:20 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb2611695e556262a52a3e1f64105844f225a925

commit fb2611695e556262a52a3e1f64105844f225a925
Author:     Brahmajit Das <[e-mail]>
AuthorDate: 2023-06-19 18:22:25 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2023-06-19 20:42:02 +0000

    games-util/dzip: Fix incompatible function pointer types passing int
    
    Closes: https://bugs.gentoo.org/884923
    Signed-off-by: Brahmajit Das <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/31545
    Signed-off-by: James Le Cuirot <[e-mail]>

 games-util/dzip/dzip-2.9-r5.ebuild                 | 41 ++++++++++++++++++++++
 games-util/dzip/files/dzip-clang16-build-fix.patch | 14 ++++++++
 2 files changed, 55 insertions(+)