Bug 884717

Summary:	dev-libs/libxslt: Build with large file support
Product:	Gentoo Linux	Reporter:	Allen Webb <allenwebb>
Component:	Current packages	Assignee:	Sam James <sam>
Status:	RESOLVED FIXED
Severity:	normal	CC:	base-system, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	471102

Description Allen Webb 2022-12-07 16:48:10 UTC

On ChromeOS we get the QA error:
```
16:45:38.435  * QA Notice: The following files were not built with LFS support:
16:45:38.449  *   Please see https://issuetracker.google.com/201531268 for details.
16:45:38.463  * fopen,stat /usr/lib/libxslt.so.1.1.37
16:45:38.476  * Full build files:
stat /build/beaglebone/tmp/portage/dev-libs/libxslt-1.1.37/work/libxslt-1.1.37-.arm/libxslt/.libs/security.o
fopen,stat /build/beaglebone/tmp/portage/dev-libs/libxslt-1.1.37/work/libxslt-1.1.37-.arm/libxslt/.libs/libxslt.so.1.1.37
fopen /build/beaglebone/tmp/portage/dev-libs/libxslt-1.1.37/work/libxslt-1.1.37-.arm/libxslt/.libs/transform.o

 * ERROR: dev-libs/libxslt-1.1.37::portage-stable failed:
 *   package needs LFS support enabled -- see https://issuetracker.google.com/201531268
```

Adding the large file support flags resolves the issue.

Reproducible: Always

Comment 1 Sam James archtester

2022-12-07 16:51:20 UTC

Would you mind making a PR upstream to add AC_SYS_LARGEFILE to configure.ac?

Comment 2 Allen Webb 2022-12-07 16:56:14 UTC

I am getting a pull request ready

Comment 3 Sam James archtester

2022-12-07 16:58:17 UTC

(In reply to Allen Webb from comment #2)
> I am getting a pull request ready

Thank you!

Comment 4 Allen Webb 2022-12-07 17:08:05 UTC

(In reply to Sam James from comment #3)
> (In reply to Allen Webb from comment #2)
> > I am getting a pull request ready
> 
> Thank you!

The pull request is here:
https://github.com/gentoo/gentoo/pull/28592

I might need to do cleanup to so it links properly with the bug. It has been a little while since I have done one of these.

Comment 5 Larry the Git Cow gentoo-dev

2022-12-07 17:51:04 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=01b65c1ab8739171aa41a3ff28bc1c2fef2f8f46

commit 01b65c1ab8739171aa41a3ff28bc1c2fef2f8f46
Author:     Allen Webb <allenwebb@google.com>
AuthorDate: 2022-12-07 17:02:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-07 17:50:27 +0000

    dev-libs/libxslt: Enable LFS support
    
    switch to using LFS-capable functions:
    
            fopen   -> fopen64
            gzopen  -> gzopen64
            readdir -> readdir64
            stat    -> stat64
    
    Closes: https://bugs.gentoo.org/884717
    Signed-off-by: Allen Webb <allenwebb@google.com>
    Closes: https://github.com/gentoo/gentoo/pull/28592
    Signed-off-by: Sam James <sam@gentoo.org>

 .../libxslt/{libxslt-1.1.37.ebuild => libxslt-1.1.37-r1.ebuild}     | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)