Summary: | >=sys-devel/make-4.4 incorrectly parallelizes sys-devel/gcc[lto] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | matoro <matoro_gentoo> |
Component: | Current packages | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arsen, bugzilla, gentoo, ionen, kfm, matoro_gentoo, sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://savannah.gnu.org/bugs/index.php?57242 https://bugs.gentoo.org/show_bug.cgi?id=885501 https://bugs.gentoo.org/show_bug.cgi?id=891909 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 879081 |
Description
matoro
2022-12-07 07:28:01 UTC
The commit you linked seems unrelated, however the one straight after it seems quite related (53e3b2bf16a486c15c20991c6095f7be09012b55). [[ or, more likely, the commit you linked was made to facilitate 53e3b2bf16a486c15c20991c6095f7be09012b55 ]] I'll try reproducing now, I hesitated at first since I first need a copy of 12.2.1_p20221008 (I'm on 12.2.1_p20221203 and 13) Ok, the latest GCC 12 snapshot indeed omits support for fifo: jobservers. I think it's probably better to backport that than to mask make, though. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=f91690729a34d00f90b7303a51f7952105696196 commit f91690729a34d00f90b7303a51f7952105696196 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-09 11:04:30 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-09 11:24:01 +0000 12.2: backport make 4.4 jobserver fixes Bug: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> .../78_all_Factor-out-jobserver_active_p.patch | 301 +++++++++++++++++++++ ...-jobserver-style-fifo-for-recent-GNU-make.patch | 73 +++++ ...spect-jobserver-in-parallel-WPA-streaming.patch | 237 ++++++++++++++++ ...ix-fifo-mode-by-opening-pipe-in-proper-mo.patch | 37 +++ 12.2.0/gentoo/README.history | 7 +- 5 files changed, 654 insertions(+), 1 deletion(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb34ab687d83e8b93245944d6a59b46390594148 commit fb34ab687d83e8b93245944d6a59b46390594148 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-09 11:24:29 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-09 11:25:09 +0000 sys-devel/gcc: bump 12.2.1_p20221203 to patchset 12.2.0 patchset 4 This is for the make 4.4 jobserver fixes. Note that GCC 10 & 11 still need backports. Bug: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> sys-devel/gcc/Manifest | 2 +- sys-devel/gcc/gcc-12.2.1_p20221203.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Note: - GCC 10 & 11 are pending backports. - No revbump done for 12 yet (this can affect packages building using -flto=jobserver, not just GCC itself, but this isn't very common) as I plan to keyword the next snapshot which is due in 2 days anyway The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=90d6e02b9980b278cb63f2b8e79b0a29dab5262f commit 90d6e02b9980b278cb63f2b8e79b0a29dab5262f Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-17 02:49:35 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-17 04:54:05 +0000 Revert "11.4.0: backport make 4.4 jobserver fixes" Not complete but wanted to commit it for posterity in case we want to resume it. This reverts commit 54c43babcc6a7b957ef59725b5b54608517e6fb0. Bug: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> 11.4.0/gentoo/README.history | 4 ---- 1 file changed, 4 deletions(-) https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=6b7210b745d69eee33e5eda1a7ed5fa6ee93c003 commit 6b7210b745d69eee33e5eda1a7ed5fa6ee93c003 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-17 02:49:23 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-17 04:54:05 +0000 Revert "10.5.0: backport make 4.4 jobserver fixes" Not complete but wanted to commit it for posterity in case we want to resume it. This reverts commit b0521a3be4d9d67a7190126e58440c4904924744. Bug: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> .../77_all_Factor-out-jobserver_active_p.patch | 320 --------------------- ...-jobserver-style-fifo-for-recent-GNU-make.patch | 66 ----- 10.5.0/gentoo/README.history | 4 - 3 files changed, 390 deletions(-) https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=e8a0be0130af739172f5f694a782c684fd341c09 commit e8a0be0130af739172f5f694a782c684fd341c09 Author: Arsen Arsenović <arsen@aarsen.me> AuthorDate: 2022-12-09 14:41:40 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-17 04:54:04 +0000 11.4.0: backport make 4.4 jobserver fixes Bug: https://bugs.gentoo.org/884633 Signed-off-by: Arsen Arsenović <arsen@aarsen.me> Signed-off-by: Sam James <sam@gentoo.org> 11.4.0/gentoo/README.history | 4 ++++ 1 file changed, 4 insertions(+) https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=a535dea3848bd10f950f72281bb7d1563586d1d8 commit a535dea3848bd10f950f72281bb7d1563586d1d8 Author: Arsen Arsenović <arsen@aarsen.me> AuthorDate: 2022-12-09 14:37:14 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-17 04:54:04 +0000 10.5.0: backport make 4.4 jobserver fixes Bug: https://bugs.gentoo.org/884633 Signed-off-by: Arsen Arsenović <arsen@aarsen.me> Signed-off-by: Sam James <sam@gentoo.org> .../77_all_Factor-out-jobserver_active_p.patch | 320 +++++++++++++++++++++ ...-jobserver-style-fifo-for-recent-GNU-make.patch | 66 +++++ 10.5.0/gentoo/README.history | 4 + 3 files changed, 390 insertions(+) Done upstream in 10 and 11 respectively: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=51e819e99f3e800d2fb1cb22b4648e6d0558e35b https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=c4de50835f731b301bd8161be5318de701f2864a The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77c516ccbbb90dd43e12ebd7cfa3642f786762ac commit 77c516ccbbb90dd43e12ebd7cfa3642f786762ac Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-22 22:46:47 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-22 22:46:47 +0000 sys-devel/gcc: add 10.4.1_p20221222 Bug: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> sys-devel/gcc/Manifest | 1 + sys-devel/gcc/gcc-10.4.1_p20221222.ebuild | 58 +++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=316d250ee4d7bf08015da05b04e56264735cb178 commit 316d250ee4d7bf08015da05b04e56264735cb178 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-24 01:42:05 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-24 01:44:30 +0000 sys-devel/gcc: add 11.3.1_p20221223 As remarked on IRC, this + the last GCC 10 snapshot + GCC 12 tomorrow are likely the last ones to be keyworded for a little while, as we want the make 4.4 fixes, with the exception of 12 which might get another one kewyorded beyond this weekend if there's a fix for the PPC + LLVM issues. Bug: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> sys-devel/gcc/Manifest | 1 + sys-devel/gcc/gcc-11.3.1_p20221223.ebuild | 52 +++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) (In reply to Arsen Arsenovic from comment #7) > Done upstream in 10 and 11 respectively: > > https://gcc.gnu.org/git/?p=gcc.git;a=commit; > h=51e819e99f3e800d2fb1cb22b4648e6d0558e35b > https://gcc.gnu.org/git/?p=gcc.git;a=commit; > h=c4de50835f731b301bd8161be5318de701f2864a Thanks for doing these! The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bdf7258fd2b4c203d62aeaaa38d63227ad36f384 commit bdf7258fd2b4c203d62aeaaa38d63227ad36f384 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-25 17:02:10 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-25 17:02:18 +0000 sys-devel/gcc: add 12.2.1_p20221224 See 316d250ee4d7bf08015da05b04e56264735cb178. Closes: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> sys-devel/gcc/Manifest | 2 ++ sys-devel/gcc/gcc-12.2.1_p20221224.ebuild | 52 +++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=d182e15bbb3333f34afd4a6396108c1e581e4872 commit d182e15bbb3333f34afd4a6396108c1e581e4872 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-25 16:57:30 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-25 16:57:30 +0000 12.2.0: drop upstreamed make 4.4 patches Bug: https://bugs.gentoo.org/884633 Signed-off-by: Sam James <sam@gentoo.org> .../78_all_Factor-out-jobserver_active_p.patch | 284 --------------------- ...-jobserver-style-fifo-for-recent-GNU-make.patch | 64 ----- ...spect-jobserver-in-parallel-WPA-streaming.patch | 225 ---------------- ...ix-fifo-mode-by-opening-pipe-in-proper-mo.patch | 31 --- 12.2.0/gentoo/README.history | 6 + 5 files changed, 6 insertions(+), 604 deletions(-) |