Bug 884415 – dev-tcltk/tdom-0.9.2 fails to compile (CLANG-STRICTER-SYSTEM): tdomStubInit.c:33:5: error: incompatible function pointer types initializing SchemaData ()(void) (aka struct SchemaData_ ()(void)) with an expression of type SchemaData (Tcl_Interp ) (aka str

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-12-05 07:57:36 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-tcltk/tdom-0.9.2 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-05 07:57:39 UTC]

Created attachment 840193 [details]
build.log

build log and emerge --info

[Comment 2 Carlos 2022-12-31 21:27:31 UTC]

Created attachment 846284 [details, diff]
Fixed tdom-0.9.2-nothreads.patch

This is due to tdom-0.9.2-no-threads.patch changing tdomGetSchemadata's prototype only at the top of the header, but not on the following struct. I'm proposing a revision that makes the changes in both places.

By the way, tdom 0.9.3 won't need this patch, and is not affected.

[Comment 3 Larry the Git Cow 2023-01-18 19:41:27 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe5a5b96e8920196238a55b8c39e5f31adfc88a6

commit fe5a5b96e8920196238a55b8c39e5f31adfc88a6
Author:     Alfredo Tupone <[e-mail]>
AuthorDate: 2023-01-18 19:40:40 +0000
Commit:     Alfredo Tupone <[e-mail]>
CommitDate: 2023-01-18 19:40:40 +0000

    dev-tcltk/tdom: clang6
    
    Closes: https://bugs.gentoo.org/884415
    Signed-off-by: Alfredo Tupone <[e-mail]>

 dev-tcltk/tdom/files/tdom-0.9.2-clang6.patch               | 11 +++++++++++
 dev-tcltk/tdom/{tdom-0.9.2.ebuild => tdom-0.9.2-r1.ebuild} |  3 ++-
 2 files changed, 13 insertions(+), 1 deletion(-)

[Comment 4 Larry the Git Cow 2023-01-19 07:07:36 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42267f3f7730c31ad246d7ea62357fe1a240bff3

commit 42267f3f7730c31ad246d7ea62357fe1a240bff3
Author:     Alfredo Tupone <[e-mail]>
AuthorDate: 2023-01-19 07:07:01 +0000
Commit:     Alfredo Tupone <[e-mail]>
CommitDate: 2023-01-19 07:07:20 +0000

    dev-tcltk/tdom: add 0.9.3
    
    Bug: https://bugs.gentoo.org/884415
    Signed-off-by: Alfredo Tupone <[e-mail]>

 dev-tcltk/tdom/Manifest          |  1 +
 dev-tcltk/tdom/tdom-0.9.3.ebuild | 79 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+)