Bug 884413

Summary:	dev-tcltk/snack-2.2.10-r10 fails to compile (CLANG-STRICTER-SYSTEM): sigproc2.c:468:25: error: parameter type was not declared, defaults to int; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	TCL/TK Project <tcltk>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-05 07:53:41 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-tcltk/snack-2.2.10-r10 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-05 07:53:43 UTC

Created attachment 840191 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2023-01-16 07:31:54 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b9ad99d5952087da5f262c4e20f236749b33f0d

commit 8b9ad99d5952087da5f262c4e20f236749b33f0d
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2023-01-16 07:30:58 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2023-01-16 07:31:37 +0000

    dev-tcltk/snack: fix implicit warnings
    
    Closes: https://bugs.gentoo.org/884413
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 dev-tcltk/snack/files/snack-2.2.10-implicit.patch | 92 +++++++++++++++++++++++
 dev-tcltk/snack/snack-2.2.10-r11.ebuild           |  1 +
 2 files changed, 93 insertions(+)