Bug 883813

Summary:	dev-python/h5py-3.7.0 fails to compile (CLANG-STRICTER-SYSTEM): _errors.c:2180:64: error: incompatible function pointer types passing herr_t (int, H5E_error2_t , void ) (aka int (int, struct H5E_error2_t , void )) to parameter of type H5E_walk2_t (aka in
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Python Gentoo Team <python>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sci
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/h5py/h5py/pull/2142
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-01 07:43:51 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/h5py-3.7.0 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-01 07:43:54 UTC

Created attachment 838647 [details]
build.log

build log and emerge --info

Comment 2 Sam James archtester

2022-12-01 07:56:48 UTC

https://github.com/h5py/h5py/commit/873077a5b132c4294f0ea6af2eb29d61352c6688

Comment 3 Larry the Git Cow gentoo-dev

2022-12-01 14:35:19 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a1c3e816e104ea1e0833fd1c8cc2f529c879469

commit 0a1c3e816e104ea1e0833fd1c8cc2f529c879469
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-12-01 14:32:20 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-12-01 14:32:39 +0000

    dev-python/h5py: Backport -Wincompatible-function-pointer-types fix
    
    Closes: https://bugs.gentoo.org/883813
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/h5py/files/h5py-3.7.0-types.patch | 36 ++++++++++++++++++++++++++++
 dev-python/h5py/h5py-3.7.0.ebuild            |  4 ++++
 2 files changed, 40 insertions(+)