Summary: | media-libs/gegl-0.4.40 build failure with clang-15 -Werror=strict-prototypes | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Carlos <carana2099> |
Component: | Current packages | Assignee: | Sergey Torokhov <torokhov-s-a> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ionen, proxy-maint, sam |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://gitlab.gnome.org/GNOME/gegl/-/merge_requests/132 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 880545 | ||
Attachments: |
build.log
patch adding (void) to prototypes where needed |
Description
Carlos
2022-11-27 15:35:37 UTC
Created attachment 837737 [details]
build.log
Created attachment 837739 [details, diff] patch adding (void) to prototypes where needed Signed-off-by: Carlos Eduardo (carana2099@gmail.com) There's not really a need to fix missing (void) because not specifying it is set to become valid in C2x (aka clang -std=gnu2x -Werror=strict-prototypes doesn't error out with a `int main() { return 0; }`, but e.g. -std=gnu99 does). It's a subset of strict-prototypes that's an issue and will be broken in C2x (-Werror=deprecated-non-prototype) unless an older -std= is passed making it a non-issue. It's worth fixing these once you hit them just to avoid more reports like this but indeed no need to do it proactively (we've dropped strict-prototypes from stricter mode for Clang 15 because of the problems ionen described). Would you mind sending this upstream too? Thank you! (I'll add c23-porting blocker as it's close enough.) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b67509015dbe51f15a0c7d3f4c316826dc927de commit 1b67509015dbe51f15a0c7d3f4c316826dc927de Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-21 23:46:58 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-21 23:52:00 +0000 media-libs/gegl: fix -Wstrict-prototypes Signed-off-by: Carlos Eduardo <carana2099@gmail.com> Closes: https://bugs.gentoo.org/883313 Signed-off-by: Sam James <sam@gentoo.org> .../gegl/files/gegl-0.4.40-strict-prototypes.patch | 79 ++++++++++++++++++++++ media-libs/gegl/gegl-0.4.40-r1.ebuild | 4 ++ 2 files changed, 83 insertions(+) Sam James, thank you for fix the ebuild |