Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 883307

Summary: sys-apps/portage: env-update skips setting PATH to work around a seemingly out-of-date issue
Product: Portage Development Reporter: Arsen Arsenović <arsen>
Component: UnclassifiedAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal CC: arfrever.fta, flow, kacper.slominski72
Priority: Normal Keywords: InVCS
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/portage/pull/949
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 883437    
Bug Blocks:    

Description Arsen Arsenović gentoo-dev 2022-11-27 14:47:07 UTC 
After running env-update, 10-gentoo-env lacks the PATH variable, leading to user services starting with trimmed paths (e.g. lacking /usr/lib/llvm/15/bin, and so, clangd)

The code that does this skip was added here:
https://gitweb.gentoo.org/proj/portage.git/commit/lib/portage/util/env_update.py?id=21739ea1e0a793e207b7ae28d524e45582d9b2ca
I couldn't find an issue that talks about this upstream.  I could replace PAGER just fine via systemctl --user import-environment, and from searching about systemd code a bit, I couldn't find any reason why replacing PATH wouldn't work just the same, since both would be set in /etc/environment.d/10-gentoo-env.conf just the same.

(I changed PATH too, and it had the desired effect, at least on show-environment, but I figured PAGER is a better test since PATH is not set)

Reproducible: Always

Steps to Reproduce:
1. env-update
2. grep ^PATH= /etc/environment.d/10-gentoo-env.conf
Actual Results:  
No output.

Expected Results:  
PATH=...

[i] ~ 130 $ emerge --info
Portage 3.0.39 (python 3.10.8-final-0, default/linux/amd64/17.1/desktop/plasma/systemd/merged-usr, gcc-12, glibc-2.36-r5, 5.19.16-gentoo-dist x86_64)
=================================================================
System uname: Linux-5.19.16-gentoo-dist-x86_64-AMD_Ryzen_7_3800X_8-Core_Processor-with-glibc2.36
KiB Mem:    65794512 total,  52796132 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Sun, 27 Nov 2022 02:30:01 +0000
Head commit of repository gentoo: ecd053a8db9abdc32450577c4328e926f50bf520
Timestamp of repository guru: Sat, 26 Nov 2022 21:17:50 +0000
Head commit of repository guru: 7d725d19f37091bfa7e074d1d1e30adcc010eee7

Timestamp of repository haskell: Sat, 26 Nov 2022 21:17:34 +0000
Head commit of repository haskell: 1bd41bd0d57898325dca307a8a709d7f64229fe2

Timestamp of repository nix-guix: Fri, 25 Nov 2022 22:48:47 +0000
Head commit of repository nix-guix: 360ac6978671f3d1c29de981549534bc3f804b76

Timestamp of repository qt: Sat, 26 Nov 2022 21:17:36 +0000
Head commit of repository qt: 6d5419cf31a1f6c6982788587230c05c1182f3f6

Timestamp of repository steam-overlay: Sat, 26 Nov 2022 21:17:38 +0000
Head commit of repository steam-overlay: 7725952b048be2987eb0a39b2641a03b30df8f44

sh bash 5.2_p12
ld GNU ld (Gentoo 2.39 p5) 2.39.0
distcc 3.4 x86_64-pc-linux-gnu [disabled]
ccache version 4.7.4 [disabled]
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.2_p12::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0-r1::gentoo
dev-lang/python:           2.7.18_p16::gentoo, 3.10.8_p3::gentoo, 3.11.0_p2::gentoo
dev-lang/rust:             1.65.0::gentoo
dev-util/ccache:           4.7.4::gentoo
dev-util/cmake:            3.25.0::gentoo
dev-util/meson:            0.64.1::gentoo
sys-apps/baselayout:       2.9::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          252.2::gentoo
sys-devel/autoconf:        2.69-r8::localrepo, 2.71-r5::gentoo
sys-devel/automake:        1.15.1-r3::localrepo, 1.16.5::gentoo
sys-devel/binutils:        2.39-r4::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.6-r1::gentoo, 15.0.5::gentoo
sys-devel/gcc:             12.2.1_p20221119::gentoo, 13.0.0_pre20221120::gentoo
sys-devel/gcc-config:      2.8::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             15.0.5::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo, 15.0.5::gentoo
sys-devel/make:            4.4::gentoo
sys-kernel/linux-headers:  6.0::gentoo (virtual/os-headers)
sys-libs/glibc:            2.36-r5::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 12
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo

haskell
    location: /var/db/repos/haskell
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/haskell.git
    masters: gentoo

localrepo
    location: /var/db/repos/localrepo
    masters: gentoo

nix-guix
    location: /var/db/repos/nix-guix
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/nix-guix.git
    masters: gentoo

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo

crossdev
    location: /usr/local/portage-crossdev
    masters: gentoo
    priority: 10

Installed sets: @imhex, @rockbox, @solaar, @steam, @xsecurelock
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --ask --ask-enter-invalid --quiet-build --tree"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg buildpkg-live cgroup config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS=" 	http://tux.rainside.sk/gentoo/ http://mirror.wheel.sk/gentoo 	https://mirror.wheel.sk/gentoo "
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j17 -l16"
PKGDIR="/var/cache/binpkgs"
PORTAGE_COMPRESS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aac acl acpi activities amd64 bash-completion bluetooth branding bzip2 cairo cdda cdr cli completion crypt cups dbus declarative dist-kernel dri dts dvd dvdr emacs encode exif flac fortran gdbm gif gpm graphicsmagic gtk gui hunspell iconv icu introspection ipv6 jpeg kde kwallet lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses networkmanager nls nptl offensive ogg opengl openmp openssl pam pango pcre pdf pipewire plasma png policykit ppds pulseaudio qml qt5 readline sdl seccomp semantic-desktop spell ssl startup-notification svg systemd test-rust tiff truetype udev udisks unicode upower usb vdpau vorbis wayland widgets wxwidgets x264 xattr xcb xinerama xml xv xvid zlib zsh-completion" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx f16c fma3 pclmul popcnt rdrand sse3 sse4_1 sse4_2 sse4a ssse3" CURL_SSL="openssl" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="WebAssembly BPF AMDGPU NVPTX" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10 pypy3" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="nvidia intel i915" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

[i] ~$
Comment 1 Larry the Git Cow gentoo-dev 2022-11-30 22:29:03 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=f99ddf5659d143dd876ab05c5ff2ce425ffde672

commit f99ddf5659d143dd876ab05c5ff2ce425ffde672
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2022-11-27 19:12:53 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-30 22:28:58 +0000

    Revert "env-update: skip PATH in systemd user environment definition"
    
    This reverts commit 21739ea1e0a793e207b7ae28d524e45582d9b2ca, as it
    was appearantly not necessary. Not sure what drove me into believing
    that this was needed…
    
    Thanks to Arsen for pointing this out.
    
    Closes: https://bugs.gentoo.org/883307
    Reported-by: Arsen Arsenović <arsen@aarsen.me>
    Signed-off-by: Florian Schmaus <flow@gentoo.org>
    Closes: https://github.com/gentoo/portage/pull/949
    Signed-off-by: Sam James <sam@gentoo.org>

 NEWS                           | 3 +++
 lib/portage/util/env_update.py | 5 -----
 2 files changed, 3 insertions(+), 5 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2022-12-01 05:17:53 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=457170222d9a1133406b90955269580e4db2ee2b

commit 457170222d9a1133406b90955269580e4db2ee2b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-01 05:16:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-01 05:16:52 +0000

    sys-apps/portage: add 3.0.40
    
    Closes: https://bugs.gentoo.org/814380
    Closes: https://bugs.gentoo.org/850127
    Closes: https://bugs.gentoo.org/881383
    Closes: https://bugs.gentoo.org/883071
    Closes: https://bugs.gentoo.org/883307
    Closes: https://bugs.gentoo.org/883437
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.40.ebuild | 283 +++++++++++++++++++++++++++++++++
 2 files changed, 284 insertions(+)