Bug 883237

Summary:	dev-db/repmgr-5.1.0 fails to compile (CLANG-STRICTER-SYSTEM): repmgr-client.c:179:18: error: incompatible integer to pointer conversion initializing struct passwd with an expression of type int [-Wint-conversion]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/32010
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	870412
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-11-27 08:52:22 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-db/repmgr-5.1.0 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-11-27 08:52:24 UTC

Created attachment 837343 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2023-08-22 07:24:13 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e66c27b7c9f88c5036a0511e9e08a92ae4785ef3

commit e66c27b7c9f88c5036a0511e9e08a92ae4785ef3
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-07-23 07:35:11 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-08-22 06:49:09 +0000

    dev-db/repmgr: Fix incompatible integer to pointer conversion
    
    Closes: https://bugs.gentoo.org/883237
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/32010
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 ...repmgr-5.1.0-fix-missing-getpwuid-clang16.patch | 12 ++++++
 dev-db/repmgr/repmgr-5.1.0-r1.ebuild               | 47 ++++++++++++++++++++++
 2 files changed, 59 insertions(+)