Bug 882421 – sys-apps/portage - desktop file validation may dump binary data to terminal

• Product: Portage Development
• Status: UNCONFIRMED ---

[Description Michael 2022-11-21 20:48:33 UTC]

If the binary and the .desktop file have the same base name, e.g. "name.desktop" and "name", a call like `newmenu name newname` dumps megabytes of binary garbage into the terminal.

Things like:

<------>^A^B ^A^B"^A^B$^A^B&^A^B(^A^B*^A^B,^A^B.^A^B0^A^B2^A^B4^A^B6^A^B8^A^B:^A^B<^A^B>^A^B@^A^BB^A^BD^A^BF^A^BH^A^BJ^A^BL^A^BN^A^BP^A^BR^A^BT^A^BV^A^BX^A
<------>^A^Bύ��i���x�z�_��ꖫ�փ!", which is not a comment, a group or an entry

I'm sure the warnings about invalid .desktop file are very correct, but there's _a lot_ of them.

[Comment 1 Ionen Wolkens 2022-11-21 20:55:26 UTC]

newmenu doesn't have implicit .desktop, it installs what you tell it to

e.g. newmenu name.desktop newname.desktop

If you omit .desktop, then you're installing the wrong thing.

[Comment 2 Michael 2022-11-21 21:03:51 UTC]

(In reply to Ionen Wolkens from comment #1)
> newmenu doesn't have implicit .desktop, it installs what you tell it to
> 
> e.g. newmenu name.desktop newname.desktop
> 
> If you omit .desktop, then you're installing the wrong thing.


I get that I did the wrong thing, although I think it installed the .desktop too.
But what portage did there wasn't pretty. Especially with dumping non-ascii's in the terminal. My summary.log is now 7MB. ;-)

[Comment 3 Mike Gilbert 2022-11-22 16:58:39 UTC]

> But what portage did there wasn't pretty.

That would be a bug in portage, not desktop.eclass.

[Comment 4 Michael 2022-11-22 18:17:21 UTC]

(In reply to Mike Gilbert from comment #3)

> That would be a bug in portage, not desktop.eclass.

Fair enough.