Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 8822

Summary: metacity-setup-0.7.1 doesn't detect themes properly
Product: Gentoo Linux Reporter: Jonathan Nall <nall>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: 1.4_rc1   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch for metacity-setup-0.7.1 to recognize themes properly
ebuild to incorporate my patch

Description Jonathan Nall 2002-10-06 16:44:10 UTC
metacity-setup will emerge, but doesn't really detect themes properly. i hacked
on it this morning, and am attaching a new ebuild file and the patch. the
program now recognizes my themes and changes them.

the issue was that metacity-setup was looking for:
<theme_dir>/THEME_NAME/metacity-theme-1.xml

but all of the themes i've installed use the form:
<theme_dir>/THEME_NAME/metacity-1/metacity-theme-1.xml

my patch adds this second path as a valid form and voila! things started
to work.
Comment 1 Jonathan Nall 2002-10-06 16:45:20 UTC
Created attachment 4463 [details, diff]
patch for metacity-setup-0.7.1 to recognize themes properly
Comment 2 Jonathan Nall 2002-10-06 16:46:16 UTC
Created attachment 4464 [details]
ebuild to incorporate my patch

this ebuild will apply my patch (attachment# 4463 [details, diff]) to metacity-setup-0.7.1.
Comment 3 Markus Bertheau (RETIRED) gentoo-dev 2002-10-09 00:03:08 UTC
Great work, thanks. I'm sure Spider is happy on this one, too :) Did you send
the patch to the metacity-setup author, too?
Comment 4 foser (RETIRED) gentoo-dev 2002-10-09 06:06:48 UTC
Added this patch and bumped the ebuilds revision. Thanks for the patch and
please send it upstream to the author.

Did you really test it with ppc btw ?
Comment 5 Jonathan Nall 2002-10-09 07:39:40 UTC
I'll send this to the metacity-setup author. I did test on PPC (and only on PPC).