| Summary: | media-libs/libplacebo-5.229.1[-vulkan] fails to build | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Maciej S. Szmigiero <mail> |
| Component: | Current packages | Assignee: | Ionen Wolkens <ionen> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ionen |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/41027 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
That doesn't seem like a good idea, results in the library not being installed if vulkan headers are really not found and the error is bypassed. --- filelist-before (with headers) +++ filelist-after (with patch, without headers) @@ -28,7 +28,4 @@ /usr/include/libplacebo/utils/libav_internal.h /usr/include/libplacebo/utils/upload.h /usr/include/libplacebo/vulkan.h -/usr/lib64/libplacebo.so -/usr/lib64/libplacebo.so.229 -/usr/lib64/pkgconfig/libplacebo.pc /usr/share/doc/libplacebo-5.229.1/README.md.zst Looking at src/common.h it always uses vulkan/vulkan.h so seems like it can't do without even with USE=-vulkan (figures it's not normally bundled for nothing). Guess keeping the USE is questionable, but disabling it still allows building it as a stub and skipping vulkan-loader dep, guess I'll just make vulkan-headers a hard requirement for now. > That doesn't seem like a good idea, > results in the library not being installed if vulkan headers are really not found. Right, haven't noticed the missing library previously. > guess I'll just make vulkan-headers a hard requirement for now. Ack. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b11f3a432af8a4b64f7c5c8de35594410bf46dd commit 7b11f3a432af8a4b64f7c5c8de35594410bf46dd Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2022-11-20 01:16:33 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2022-11-20 01:29:59 +0000 media-libs/libplacebo: always require vulkan-headers Closes: https://bugs.gentoo.org/882065 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> media-libs/libplacebo/libplacebo-5.229.1.ebuild | 3 ++- media-libs/libplacebo/libplacebo-9999.ebuild | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) |
media-libs/libplacebo-5.229.1[-vulkan] fails to build, saying that vulkan.h is required. This system does NOT have dev-util/vulkan-headers installed. Quick fix to make the package build successfully in this config: --- a/src/vulkan/meson.build +++ b/src/vulkan/meson.build @@ -17,7 +17,7 @@ endif build_deps += vulkan_headers -if not vulkan_headers.found() +if vulkan_build.allowed() and not vulkan_headers.found() error('vulkan.h was not found on the system, nor inside ' + '`3rdparty/Vulkan-Headers`. Please run `git submodule update --init` ' + 'followed by `meson --wipe`.')