Bug 881989 – app-arch/createrepo_c-0.20.1 fails to compile (CLANG-STRICTER-SYSTEM): xml_parser_other.c:309:28: error: passing arguments to cr_xml_parser_data without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description Agostino Sarubbo 2022-11-19 08:46:42 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-arch/createrepo_c-0.20.1 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types -Werror=deprecated-non-prototype

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-11-19 08:46:44 UTC]

Created attachment 833625 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-11-19 08:46:45 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
FAILED: src/CMakeFiles/libcreaterepo_c.dir/xml_parser.c.o 
FAILED: src/CMakeFiles/libcreaterepo_c.dir/xml_parser_filelists.c.o 
FAILED: src/CMakeFiles/libcreaterepo_c.dir/xml_parser_other.c.o 
FAILED: src/CMakeFiles/libcreaterepo_c.dir/xml_parser_primary.c.o 
FAILED: src/CMakeFiles/libcreaterepo_c.dir/xml_parser_repomd.c.o 
FAILED: src/CMakeFiles/libcreaterepo_c.dir/xml_parser_updateinfo.c.o 
/var/tmp/portage/app-arch/createrepo_c-0.20.1/work/createrepo_c-0.20.1/src/xml_parser_other.c:309:28: error: passing arguments to 'cr_xml_parser_data' without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]

[Comment 3 Sam James 2022-11-19 08:54:01 UTC]

This has -std=gnu99 so I wouldn't expect it to warn without the -Werror (i.e. you're opting in to it, rather than letting it happen "naturally" where implied default is C17 or whatever and it really will break when default changes.)