Bug 881959

Summary:	app-admin/hardinfo-0.6_alpha_pre20221113 fails to compile (CLANG-STRICTER-SYSTEM): fbench.c:651:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED INVALID
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	880545
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-11-19 08:31:12 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/hardinfo-0.6_alpha_pre20221113 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types -Werror=deprecated-non-prototype

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

Comment 1 Agostino Sarubbo gentoo-dev

2022-11-19 08:31:15 UTC

Created attachment 833595 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2022-11-19 08:31:16 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: CMakeFiles/benchmark.dir/modules/benchmark/fbench.c.o 
FAILED: CMakeFiles/benchmark.dir/modules/benchmark/md5.c.o 
/var/tmp/portage/app-admin/hardinfo-0.6_alpha_pre20221113/work/hardinfo-a798cbaed6f1b083cc3c26dbede74cf40947d0ef/modules/benchmark/fbench.c:651:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]

Comment 3 Sam James archtester

2022-11-19 08:56:30 UTC

This has -std=gnu89 so I wouldn't expect it to warn without the -Werror (i.e. you're opting in to it, rather than letting it happen "naturally" where implied default is C17 or whatever and it really will break when default changes.)