Bug 881281

Summary:	x11-misc/rofi-1.7.5 fails tests (LTO-SYSTEM): textbox.h:251:8: error: type of [-Werror=lto-type-mismatch]
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Petrus Zhao <petrus.zy.07>
Status:	RESOLVED FIXED
Severity:	normal	CC:	flow, proxy-maint
Priority:	Normal	Keywords:	UPSTREAM
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/davatorium/rofi/issues/1743
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	618550
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-11-14 09:33:47 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-misc/rofi-1.7.5 fails tests (LTO-SYSTEM).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
(LTO-SYSTEM) in the summary means that bug was found on a machine that runs lto but this bug MAY or MAY NOT BE related to lto.

This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

Comment 1 Agostino Sarubbo gentoo-dev

2022-11-14 09:33:50 UTC

Created attachment 832445 [details]
build.log

build log and emerge --info

Comment 2 Petrus Zhao 2022-11-24 06:15:48 UTC

Upstream just fixed this issue, but they don't release a new version yet. I'll close this when upstream release a new version.

Comment 3 Larry the Git Cow gentoo-dev

2024-03-17 05:34:51 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46ca7fec8948323a0b9c15866363473b76b93e90

commit 46ca7fec8948323a0b9c15866363473b76b93e90
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-17 03:07:27 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-17 05:28:38 +0000

    x11-misc/rofi: mark as LTO-unsafe
    
    Fixed upstream but we are waiting for a new version.
    
    Closes: https://bugs.gentoo.org/881281
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-misc/rofi/rofi-1.7.5.ebuild | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)