Bug 88099 – sysklogd: now with ppc64 love

• Product: Gentoo Linux
• Status: VERIFIED WONTFIX

[Description Omkhar Arasaratnam (RETIRED) 2005-04-05 16:49:06 UTC]

I managed to cobble together a patch which seems to allow sysklogd to compile under gentoo (previously undoable). It is based on the RH package and actually includes a number of fixed for "off by one" buff overflows as a side benefit. I will attach the patch file to create the neccassary ebuild joo joo

Reproducible: Always
Steps to Reproduce:

[Comment 1 Omkhar Arasaratnam (RETIRED) 2005-04-05 16:49:45 UTC]

Created attachment 55410 [details, diff]
sysklogd-ppc64-safe.patch

[Comment 2 Tom Gall (RETIRED) 2005-04-07 21:09:18 UTC]

Omkhar, 

For this kinda thing, instead of a patch that applies against the whole thing,
it's convention to submit the patch to the ebuild, and the new sysklogd-1.4.1-ppc64.patch as seperate submissions. (Least I'm weird and like it this way)

Could you do this please?

thanks!

[Comment 3 SpanKY 2005-04-07 21:11:28 UTC]

that sounds awkward but what he means is that it's normal to attach patches as sep files rather than a big patch that produces a bunch of files and the patch itself ...

[Comment 4 Omkhar Arasaratnam (RETIRED) 2005-04-08 06:11:11 UTC]

I think tgall is just being difficult (Hakuna Matata my foot!) ;-)

Ok here she is - broken out a bit

[Comment 5 Omkhar Arasaratnam (RETIRED) 2005-04-08 06:19:23 UTC]

Created attachment 55665 [details, diff]
sysklogd.diff

[Comment 6 Omkhar Arasaratnam (RETIRED) 2005-04-08 06:20:11 UTC]

Created attachment 55666 [details, diff]
sysklogd-1.4.1-ppc64.patch

This goes in files/

[Comment 7 Omkhar Arasaratnam (RETIRED) 2005-04-08 06:20:46 UTC]

moooo says larry the cow ;-)

[Comment 8 Tom Gall (RETIRED) 2005-09-09 19:47:20 UTC]

well Omkhar you uncovered a rather interesting little problem with the ppc64
asm-ppc64/signal.h file.  Basically she wasn't #ifdef'ing properly.

Plasmaroo, can you pick up this patch for the 2.6.11-r2 kernel-headers? 

patch attached in next comment

[Comment 9 Tom Gall (RETIRED) 2005-09-09 19:52:04 UTC]

Created attachment 68076 [details, diff]
fix b0rked asm-ppc64/signal.h

[Comment 10 Tom Gall (RETIRED) 2005-09-09 19:53:53 UTC]

Created attachment 68077 [details, diff]
rework of omkhar's foo

This patch is a rework and applies cleanly on top of the current sysklog
version. It applies to all archies so soon as plasmaroo works his magic,  we'll
wanna see about getting all the appropriate parties on board to pick up this
patch.

[Comment 11 Brent Baude (RETIRED) 2006-09-13 17:17:24 UTC]

Closing this bug.  Omkhar has retired and syslog-ng is more than sufficient.

[Comment 12 Brent Baude (RETIRED) 2006-09-13 17:18:28 UTC]

Closing this bug.  Omkhar has retired and syslog-ng is more than sufficient.