Bug 879733

Summary:	net-libs/libotr: possible configure breakage with Clang 16
Product:	Gentoo Linux	Reporter:	Matt Jolly <kangie>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://github.com/gentoo/gentoo/pull/28218
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	906027
Attachments:	clang-14.log clang-15.log clang.diff Diff of clang15.log before and after putting eautoreconf into ebuild

Description Matt Jolly gentoo-dev

2022-11-04 22:13:31 UTC

This package has been identified via automation as potentially impacted by upcoming Clang 16 changes.
The following have been identified as potential issues:

[-Werror,-Wstrict-prototypes]

[-Werror,-Wstrict-prototypes]
error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]

Comment 1 Matt Jolly gentoo-dev

2022-11-04 22:13:32 UTC

Created attachment 827447 [details]
clang-14.log

build log

Comment 2 Matt Jolly gentoo-dev

2022-11-04 22:13:33 UTC

Created attachment 827449 [details]
clang-15.log

build log

Comment 3 Matt Jolly gentoo-dev

2022-11-04 22:13:34 UTC

Created attachment 827451 [details]
clang.diff

build log

Comment 4 Pascal Jäger 2022-11-10 23:32:46 UTC

Created attachment 830703 [details, diff]
Diff of clang15.log before and after putting eautoreconf into ebuild

Comment 5 Pascal Jäger 2022-11-10 23:34:20 UTC

Right now I only have done eautoreconf. This fixes the 
error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]

See the attached diff from that, file a of the diff is a run before there was eautoreconf in the ebuild, file b with eautoreconf.

Comment 6 Larry the Git Cow gentoo-dev

2022-11-15 02:45:05 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=436525dad8e0fb1acd08213cc3c22d1c9f19e969

commit 436525dad8e0fb1acd08213cc3c22d1c9f19e969
Author:     Pascal Jäger <pascal.jaeger@leimstift.de>
AuthorDate: 2022-11-10 23:06:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-15 02:24:25 +0000

    net-libs/libotr: fix clang16 configure
    
    Closes: https://bugs.gentoo.org/879733
    
    Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/libotr/libotr-4.1.1.ebuild | 7 +++++++
 1 file changed, 7 insertions(+)