Summary: | git-r3.eclass can't run git commands during the install phase with >=dev-vcs/git-2.35.2 (safe directory) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sebastian Parborg <darkdefende> |
Component: | Eclasses | Assignee: | Michał Górny <mgorny> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | flow, gentoo, sam |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/28154 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Sebastian Parborg
2022-11-03 15:15:43 UTC
Seems like git 2.36 add this option: git config --global --add safe.directory '*' Then every directory on the system will be regarded as safe and will effectively disable this check. The "safe directory" check was added in 2.35.2 do fix a security issue: https://github.com/git-for-windows/git/security/advisories/GHSA-vw2c-22j4-2fh2 I don't think this security issue is affecting us. Could you test the patch from the linked PR? Seems to work fine for me. Thanks for the fix! The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=207a50da440b7c6bea060972a7684e792c2a84fc commit 207a50da440b7c6bea060972a7684e792c2a84fc Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2022-11-06 07:32:48 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2022-11-07 13:25:31 +0000 git-r3.eclass: Add checkout dirs as "safe" directories Mark all checkout directories as "safe" to avoid dubious ownership errors with newer git versions when the checkout directory is accessed from src_install(). Closes: https://bugs.gentoo.org/879353 Closes: https://github.com/gentoo/gentoo/pull/28154 Signed-off-by: Michał Górny <mgorny@gentoo.org> eclass/git-r3.eclass | 5 +++++ 1 file changed, 5 insertions(+) |