Bug 879237 – net-misc/curl[adns] fails test 1083

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jonathan Lovelace 2022-11-03 02:04:09 UTC]

Created attachment 826755 [details]
net-misc:curl-7.86.0-r1:20221103-012039.log.gz

=net-misc/curl-7.86.0-r1, and also 7.85.0-r2 (but not 7.84.0), fails its test suite, specifically test 1083. The relevant snippet of the build log is as follows (between the longer lines of dashes):

-----------------------------------------
../src/curl --output log/curl1083.out  --include --trace-ascii log/trace1083 --trace-time -g "http://[::1]:34851/1083" --interface ip6-localhost >log/stdout1083 2>log/stderr1083
CMD (11520): ../src/curl --output log/curl1083.out  --include --trace-ascii log/trace1083 --trace-time -g "http://[::1]:34851/1083" --interface ip6-localhost >log/stdout1083 2>log/stderr1083

 1083: protocol FAILED!
 There was no content at all in the file log/server.input.
 Server glitch? Total curl failure? Returned: 45
== Contents of files in the log/ dir after test 1083
=== Start of file commands.log
 ../src/curl --output log/curl1083.out  --include --trace-ascii log/trace1083 --trace-time -g "http://[::1]:34851/1083" --interface ip6-localhost >log/stdout1083 2>log/stderr1083
=== End of file commands.log
=== Start of file ftpserver.cmd
 Testnum 1083
=== End of file ftpserver.cmd
=== Start of file stderr1083
 curl: (45) Couldn't bind to 'ip6-localhost'
=== End of file stderr1083
=== Start of file trace1083
 21:26:47.882581 == Info:   Trying [::1]:34851...
 21:26:47.882753 == Info: Could not resolve host: ip6-localhost
 21:26:47.882759 == Info: Couldn't bind to 'ip6-localhost'
 21:26:47.882768 == Info: Closing connection 0
=== End of file trace1083
-----------------------------------------

I note that ip6-localhost is the first name for "::1" in /etc/hosts that is not also assigned to 127.0.0.1; I haven't been able to find where in the source this test is defined so as to see why it picked that name.

[Comment 1 Jonathan Lovelace 2022-11-03 02:04:32 UTC]

Created attachment 826757 [details]
emerge-info.txt

[Comment 2 Jonathan Lovelace 2022-11-30 02:25:27 UTC]

Still failing in 7.86.0-r3.

[Comment 3 Matt Jolly 2023-03-14 06:08:27 UTC]

I've had a look at this but can't manage to trigger any of the ipv6 tests on my workstation when I run a git build, and test 1083 is _always_ skipped for me (though other ipv6 tests work) seemingly due to the precheck failing in portage.

I have a suspicion that the '../resolve --ipv6 ip6-localhost' lookup in the test precheck is the why tests are skipped for me; we don't tend to *have* an interface called 'ip6-localhost' on Gentoo. It seems to be a Debian-ism.

I suspect that fixing the 'ip6-localhost' everywhere will get the tests both running *and* passing.

[Comment 4 Matt Jolly 2023-03-14 07:36:43 UTC]

This is actually an intentional test of differently-named interfaces per https://github.com/curl/curl/commit/8dfddd279b450fa460950f6bb13323c66a2256a5

When I add that entry to my hosts I can reliably reproduce the failure.

When I set USE="-adns" that test reliably passes.

I'll work with upstream to identify the root cause, but as a workaround we can skip the broken test `if use adns`.

[Comment 5 Larry the Git Cow 2023-03-23 08:59:30 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3bca090841779256251eec23164a715e3356c3f0

commit 3bca090841779256251eec23164a715e3356c3f0
Author:     Sam James <[e-mail]>
AuthorDate: 2023-03-23 08:51:32 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-03-23 08:59:13 +0000

    net-misc/curl: add 8.0.1
    
    Note that https://github.com/curl/curl/commit/372b95f77f08ae7a64a5bca53cfb342ec5a8adc9
    did get fixed in this release, although the warnings in bug 898364 weren't real
    issues here.
    
    Kangie's done a great job of upstreaming various fixes here but is away at
    the moment so I'm doing the easy bit of just bumping the ebuild.
    
    Also sorted dependencies and some other minor tweaks to comments.
    
    Bug: https://bugs.gentoo.org/902801
    Closes: https://bugs.gentoo.org/879237
    Closes: https://bugs.gentoo.org/898364
    Signed-off-by: Sam James <[e-mail]>

 net-misc/curl/Manifest                             |   2 +
 net-misc/curl/curl-8.0.1.ebuild                    | 316 +++++++++++++++++++++
 .../curl/files/curl-8.0.1-onion-resolution.patch   | 158 +++++++++++
 3 files changed, 476 insertions(+)