Bug 877885 – sci-astronomy/wcslib-7.12 fails tests (lto): tspx.f:56:72: error: type of specx does not match original declaration [-Werror=lto-type-mismatch]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-10-22 07:41:24 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-astronomy/wcslib-7.12 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-10-22 07:41:27 UTC]

Created attachment 824995 [details]
build.log

build log and emerge --info

[Comment 2 Larry the Git Cow 2024-03-17 06:44:46 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6bd615b08f0f30e39601f8c27da17eaf3443f56e

commit 6bd615b08f0f30e39601f8c27da17eaf3443f56e
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-03-17 06:11:28 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-17 06:43:34 +0000

    sci-astronomy/wcslib: mark as LTO-unsafe
    
    Closes: https://bugs.gentoo.org/877885
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 sci-astronomy/wcslib/wcslib-7.12.ebuild | 6 ++++++
 1 file changed, 6 insertions(+)

[Comment 3 Eli Schwartz 2024-05-14 05:26:02 UTC]

https://www.atnf.csiro.au/people/mcalabre/WCS/CHANGES

Upstream released 8.3 which seems to fix these issues, and a new configure option --with-bindc to opt into the fixes (requires fortran 2003).