Summary: | net-vpn/openvpn-2.5.7 fails tests (lto): <artificial>:(.text+0x1316): undefined reference to __wrap_parse_line | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Patrick McLean <chutzpah> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | gert, lg3dx6fd, paolo.pedroni, toolchain, williamh |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://github.com/OpenVPN/openvpn/issues/492 https://sourceware.org/bugzilla/show_bug.cgi?id=31956 https://bugs.gentoo.org/show_bug.cgi?id=802762 https://bugs.gentoo.org/show_bug.cgi?id=877755 https://bugs.gentoo.org/show_bug.cgi?id=871999 https://bugs.gentoo.org/show_bug.cgi?id=865275 https://bugs.gentoo.org/show_bug.cgi?id=865997 https://bugs.gentoo.org/show_bug.cgi?id=865277 https://bugs.gentoo.org/show_bug.cgi?id=865279 https://bugs.gentoo.org/show_bug.cgi?id=729772 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 618550 | ||
Attachments: | build.log |
Description
Agostino Sarubbo
![]() Created attachment 824843 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: <artificial>:(.text+0x1316): undefined reference to `__wrap_parse_line' collect2: error: ld returned 1 exit status Still in openvpn-2.6.8 OpenVPN upstream here. This is cmocka based unit test code, with gcc being called with `-Wl,--wrap=parse_line` to, well, create a link-time wrapper for `parse_line()` (which would then be __wrap_parse_line(), provided by test_argv.c). As far as I can see, the C signatures match, so there is no reason why `-flto` should be complaining here. OTOH, -Wl,-wrap is documented as "only undefined references are replaced by the linker" and maybe this fails if the linker considers all .o files as "one" (but then I'd expect a complaint about `parse_line()` which would indeed be not present). In other words: I think the compiler upsets itself here, and I do not see anything we could do about it (except not use -Wl,-wrap= and rewrite our unit test code). reproducible with net-vpn/openvpn-2.6.9 Hi Gert, thank you for commenting! What I find interesting here is that supposedly wrap *is* supposed to work with LTO (https://sourceware.org/bugzilla/show_bug.cgi?id=24406) but it doesn't here, but I've seen this kind of failure with other packages doing exactly what OpenVPN is. I may try reduce it to either better understand it and/or report a bug if there is one. I've tried to reduce it and reported it as a bfd bug at https://sourceware.org/bugzilla/show_bug.cgi?id=31956. I'm not sure if it's a real bug or if instead we need to workaround/adjust packages, let's see. H.J has kindly provided a patch (https://sourceware.org/pipermail/binutils/2024-July/135445.html) which makes OpenVPN tests build (they fail at runtime for an unrelated reason, fail with mold too with LTO, need to look into this). It also fixes bug 877755 at least. Good news: there was a bfd bug here which H.J. Lu has posted a patch for! (https://sourceware.org/bugzilla/show_bug.cgi?id=31956) Bad news: the tests fail execution (runtime) because the real definition of e.g. buffer_write_file is visible and could be inlined. It needs to be firewalled via e.g. an internal shared library. |