Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 877611

Summary: gnome-base/gnome-keyring-42.1: does not need to depend on app-crypt/gcr[gtk]
Product: Gentoo Linux Reporter: Jocelyn Mayer <l_indien>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: UNCONFIRMED ---    
Severity: minor CC: l_indien, sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/121
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: output from emerge --info =gnome-base/gnome-keyring-42.1
Proposed patch to add gtk+ dependency optional

Description Jocelyn Mayer 2022-10-19 02:41:40 UTC
for machines (servers) without any GUI, no X11, thus no GTK+ installed, gnome-keyring is able to build using app-crypt/gcr[-gtk], using a quite simple patch mostly in configure.ac file in order to add a '--disable-gtk' configure flag.

Reproducible: Always

Steps to Reproduce:
1. Choose a machine build with USE="-X -gtk'
2. Try to build gnome-keyring package
3. Configuration fails due to lack of libgcr presence
Actual Results:  
Configure script check inconditionnaly for libgcr presence, but it is absent when app-crypt/libgcr is build with '-gtk' USE flag

Expected Results:  
Adding a '--disable-gtk' to gnome-keyring configure script and make libgcr check optional.
With a small additional patch gnome-keyring is able to build and the daemon can run, even if it warns about XDISPLAY absence at startup

A merge request has been submitted to gitlab.gnome.org. Will update with the link asap.
Comment 1 Jocelyn Mayer 2022-10-19 03:13:31 UTC
Created attachment 824719 [details]
output from emerge --info =gnome-base/gnome-keyring-42.1
Comment 2 Jocelyn Mayer 2022-10-19 03:15:23 UTC
Created attachment 824721 [details, diff]
Proposed patch to add gtk+ dependency optional

This patch adds an '--disable-gtk' option to configure.ac and changes two headers inclusions, using gcr/gcr-base.h instead of gcr/gcr.h.
Comment 3 Jocelyn Mayer 2022-10-19 06:59:35 UTC
Just openned an issue on Gnome gitlab site:
https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/121