| Summary: | sys-auth/pam_skey-1.1.5-r6: does not build if build was made without nis | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jocelyn Mayer <l_indien> |
| Component: | Current packages | Assignee: | Ulrich Müller <ulm> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jstein, l_indien |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=877423 https://bugs.gentoo.org/show_bug.cgi?id=877427 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
output from emerge --info =sys-auth/pam_skey-1.1.5-r6
Ebuild patch to allow use of rpcgen tool provided by net-fs/nfs-utils |
||
|
Description
Jocelyn Mayer
2022-10-17 11:47:57 UTC
Created attachment 824589 [details]
output from emerge --info =sys-auth/pam_skey-1.1.5-r6
Created attachment 824591 [details, diff]
Ebuild patch to allow use of rpcgen tool provided by net-fs/nfs-utils
(In reply to Jocelyn Mayer from comment #0) > sys-auth/pam_skey requires rpcgen to build. > <....> After more test, I'm not actually sure that rpcgen is still used by this package. What is sure is that it builds without the need of having net-libs/libnsl installed and this does not lead to missing symbols in the pam module. Please attach the failed build.log. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/dev/ulm.git/commit/?id=c0d0b1a344f83465410dcd306bd3d45ecd461530 commit c0d0b1a344f83465410dcd306bd3d45ecd461530 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2022-10-18 09:35:58 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2022-10-18 09:35:58 +0000 pam_skey: Don't link against libnsl Bug: https://bugs.gentoo.org/877433 Signed-off-by: Ulrich Müller <ulm@gentoo.org> patchsets/pam_skey/1.1.5/07_all_no_libnsl.patch | 12 ++++++++++++ 1 file changed, 12 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6c9b7e2d639e131c8d466fffa47ccb43cc866ef6 commit 6c9b7e2d639e131c8d466fffa47ccb43cc866ef6 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2022-10-18 10:37:27 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2022-10-18 10:42:16 +0000 sys-auth/pam_skey: Don't link against libnsl EAPI 8. Don't inherit unused multilib and pam eclasses. Update HOMEPAGE and SRC_URI. Bug: https://bugs.gentoo.org/877433 Signed-off-by: Ulrich Müller <ulm@gentoo.org> sys-auth/pam_skey/Manifest | 1 + sys-auth/pam_skey/pam_skey-1.1.5-r7.ebuild | 58 ++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+) (In reply to Jocelyn Mayer from comment #3) > (In reply to Jocelyn Mayer from comment #0) > > sys-auth/pam_skey requires rpcgen to build. > > <....> > > After more test, I'm not actually sure that rpcgen is still used by this > package. I cannot reproduce that problem. Please attach a build.log showing it. > What is sure is that it builds without the need of having net-libs/libnsl > installed and this does not lead to missing symbols in the pam module. Good catch. Looks like a spurious configure check for gethostbyname which isn't needed. This should be fixed in -r7. (In reply to Ulrich Müller from comment #7) > (In reply to Jocelyn Mayer from comment #3) > > (In reply to Jocelyn Mayer from comment #0) > > > sys-auth/pam_skey requires rpcgen to build. > > > <....> > > > > After more test, I'm not actually sure that rpcgen is still used by this > > package. > > I cannot reproduce that problem. Please attach a build.log showing it. Sorry, it seems I first did my patch too quickly, copying from other packages which actually require rpcgen tool; but the actual problem wasn't there... > > > What is sure is that it builds without the need of having net-libs/libnsl > > installed and this does not lead to missing symbols in the pam module. > > Good catch. Looks like a spurious configure check for gethostbyname which > isn't needed. This should be fixed in -r7. It seems you did the proper catch ! I wasn't able to find any reference to gethostbyname in the code. Patching the configure.in to remove this check made me able to build without any issue nor missing symbol in the resulting library. Just saw the commit. Thanks ! |
