Bug 877429

Summary:	net-fs/samba-4.15.9-r1: make it able to build without NIS support
Product:	Gentoo Linux	Reporter:	Jocelyn Mayer <l_indien>
Component:	Current packages	Assignee:	Gentoo's SAMBA Team <samba>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	jstein, l_indien
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=877423
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	output from emerge --info =net-fs/samba-4.15.9-r1 Ebuild patch to add a nis USE flag Patch adding a nis option to samba build system Updated patch for version 4.15.9

Description Jocelyn Mayer 2022-10-17 11:35:09 UTC

On a system built without NIS support, with no net-libs/libnsl & net-libs/rpcsvc-proto merged, samba is currently unable to build.
The proposal is then to add a nis USE option to samba.

Reproducible: Always

Steps to Reproduce:
1. Build without NIS support, masking net-libs/libnsl and net-libs/rpcsvc-proto
2. Try to build net-fs/samba
3. Build fails
Actual Results:  
samba is not able to build without USE nis set

Expected Results:  
samba should be able to build without need of NIS

Comment 1 Jocelyn Mayer 2022-10-17 11:36:37 UTC

Created attachment 824577 [details]
output from emerge --info =net-fs/samba-4.15.9-r1

Comment 2 Jocelyn Mayer 2022-10-17 11:39:58 UTC

Created attachment 824579 [details, diff]
Ebuild patch to add a nis USE flag

Comment 3 Jocelyn Mayer 2022-10-17 11:41:18 UTC

Created attachment 824581 [details, diff]
Patch adding a nis option to samba build system

Comment 4 Sam James archtester

2022-10-17 19:26:24 UTC

(In reply to Jocelyn Mayer from comment #3)
> Created attachment 824581 [details, diff] [details, diff]
> Patch adding a nis option to samba build system

Can you send it upstream please & link the MR here? Thanks.

Comment 5 Jocelyn Mayer 2022-10-18 05:33:07 UTC

Created attachment 824653 [details, diff]
Updated patch for version 4.15.9

Since net-libs/libtirpc dependency has been added to this ebuild (long ago but after I first did patch the samba ebuild...), the configure system will use its headers from /usr/include/tirpc/rpcsvc to build when /usr/include/rpcsvc is not available without the need of a new option.
Thus, the patch can be greatly simplified as the only need is to have rpcgen tool available, either by net-libs/rpcsvc-proto, old glibc or net-fs/nfs-utils.