Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 877363

Summary: app-text/highlight-4.1: add lua 5.4 and luajit support
Product: Gentoo Linux Reporter: Jocelyn Mayer <l_indien>
Component: Current packagesAssignee: TeX project <tex>
Status: RESOLVED FIXED    
Severity: minor CC: klaus.kusche, l_indien
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=885849
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: output from emerge --info =app-text/highlight-4.1

Description Jocelyn Mayer 2022-10-17 03:20:34 UTC
In order to avoid keeping multiple lua versions installed, add lua 5.4 and luajit in LUA_COMPAT for app-text/highlight.
As for most lua dependent packages, when version 5.3 is supported, 5.4 will also be; if not, when lua 5.1 is supported, the package can usually use luajit instead.

Reproducible: Always

Steps to Reproduce:
1. Patch LUA_COMPAT variable
2. Build using LUA_SINGLE_TARGET="lua5-4"
3. or build using LUA_SINGLE_TARGET="luajit"
Actual Results:  
The current ebuild has LUA_COMPAT=( lua5-{1..3} )

Expected Results:  
Seems to be good candidate for this change:
-LUA_COMPAT=( lua5-{1..3} )
+LUA_COMPAT=( lua5-{1..4} luajit )
Comment 1 Jocelyn Mayer 2022-10-17 03:35:23 UTC
Created attachment 824487 [details]
output from emerge --info =app-text/highlight-4.1
Comment 2 Klaus Kusche 2023-04-16 10:26:25 UTC
Another vote for lua 5.4.
Highlight is the only non-5.4 ebuild on my system, forcing me down to 5.3.
Comment 3 Larry the Git Cow gentoo-dev 2023-04-18 09:03:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9af96bffe4718cdece7b3e5a8b921ba57b9e021a

commit 9af96bffe4718cdece7b3e5a8b921ba57b9e021a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-04-18 09:02:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-18 09:02:58 +0000

    app-text/highlight: enable lua5-4, luajit
    
    Closes: https://bugs.gentoo.org/877363
    Signed-off-by: Sam James <sam@gentoo.org>

 app-text/highlight/highlight-4.1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)