Bug 876427 – media-sound/beets-1.6.0 fails tests (lto)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-10-10 07:15:49 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/beets-1.6.0 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-10-10 07:15:52 UTC]

Created attachment 823366 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-10-10 07:15:54 UTC]

Error(s) that match a know pattern:


E       AssertionError: b'/var/tmp/portage/media-sound/beets-1.6.0/work/beets-1.6.0/lib/abC_ 1_2d' != b'/var/tmp/portage/media-sound/beets-1.6.0/work/beets-1.6.0/lib/abC_ 1_2 d'
E   AssertionError: b'/base/abC_ 1_2d' != b'/base/abC_ 1_2 d'
FAILED test/test_library.py::DestinationFunctionTest::test_asciify_variable
FAILED test/test_library.py::DestinationTest::test_asciify_character_expanding_to_slash

[Comment 3 Larry the Git Cow 2023-02-22 16:00:54 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d611ed29750cf1035eb1a77f5097c69bb0573d5

commit 9d611ed29750cf1035eb1a77f5097c69bb0573d5
Author:     Petr Vaněk <[e-mail]>
AuthorDate: 2023-02-22 15:16:44 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-02-22 15:59:14 +0000

    media-sound/beets: Fix tests
    
    Few tests were failing because of changes in dependencies, namely in
    dev-python/mediafile and dev-python/unidecode.
    
    Closes: https://bugs.gentoo.org/876427
    Closes: https://bugs.gentoo.org/895862
    Signed-off-by: Petr Vaněk <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 media-sound/beets/beets-1.6.0.ebuild               |  2 +
 media-sound/beets/files/1.6.0-mediafile-test.patch | 41 +++++++++++++++++++
 media-sound/beets/files/1.6.0-unicode-test.patch   | 47 ++++++++++++++++++++++
 3 files changed, 90 insertions(+)