Bug 875626 – media-libs/libopenshot-0.2.7 fails to compile (lto): catch_main.cpp:32:10: fatal error: catch.hpp: No such file or directory

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-10-06 15:13:44 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/libopenshot-0.2.7 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-10-06 15:13:47 UTC]

Created attachment 821764 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-10-06 15:13:49 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Could NOT find Resvg, using Qt SVG parsing instead (missing: Resvg_LIBRARIES Resvg_INCLUDE_DIRS) 
/var/tmp/portage/media-libs/libopenshot-0.2.7/work/libopenshot-0.2.7/tests/catch_main.cpp:32:10: fatal error: catch2/catch.hpp: No such file or directory
FAILED: tests/CMakeFiles/catch-main.dir/catch_main.cpp.o 
/var/tmp/portage/media-libs/libopenshot-0.2.7/work/libopenshot-0.2.7/tests/catch_main.cpp:32:10: fatal error: catch2/catch.hpp: No such file or directory

[Comment 3 Larry the Git Cow 2023-07-06 00:06:00 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=089d4eceb88f2ca296eca6247a803429a0728d8f

commit 089d4eceb88f2ca296eca6247a803429a0728d8f
Author:     Ninpo <[e-mail]>
AuthorDate: 2023-07-05 14:30:45 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-07-06 00:05:28 +0000

    media-libs/libopenshot: add 0.3.2
    
    Closes: https://bugs.gentoo.org/825726
    Closes: https://bugs.gentoo.org/875626
    Closes: https://bugs.gentoo.org/909641
    Signed-off-by: Ninpo <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 media-libs/libopenshot/Manifest                 |  1 +
 media-libs/libopenshot/libopenshot-0.3.2.ebuild | 98 +++++++++++++++++++++++++
 media-libs/libopenshot/metadata.xml             |  4 +-
 3 files changed, 101 insertions(+), 2 deletions(-)