Bug 875221 – media-gfx/freecad-0.20.1 fails to compile (lto): aptrte.h:304:3: error: type of teajte_ does not match original declaration [-Werror=lto-type-mismatch]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-10-05 06:59:13 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/freecad-0.20.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-10-05 06:59:16 UTC]

Created attachment 820399 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-10-05 06:59:18 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
FAILED: lib/libMEFISTO2.so 
/var/tmp/portage/media-gfx/freecad-0.20.1/work/FreeCAD-0.20.1/src/3rdParty/salomesmesh/inc/aptrte.h:304:3: error: type of ‘teajte_’ does not match original declaration [-Werror=lto-type-mismatch]

[Comment 3 Bernd 2022-12-21 07:29:03 UTC]

Reported upstream at https://discourse.salome-platform.org/t/build-issue-with-medfile-and-lto-werror-lto-type-mismatch/323

[Comment 4 Larry the Git Cow 2024-03-27 02:57:35 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6c824d8c17318aa42970dde16ab6ab616eca38db

commit 6c824d8c17318aa42970dde16ab6ab616eca38db
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-03-27 00:49:33 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-27 02:56:50 +0000

    media-gfx/freecad: mark as LTO-unsafe
    
    Closes: https://bugs.gentoo.org/875221
    Signed-off-by: Eli Schwartz <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 media-gfx/freecad/freecad-0.20.2-r1.ebuild | 7 ++++++-
 media-gfx/freecad/freecad-0.20.2-r2.ebuild | 7 ++++++-
 media-gfx/freecad/freecad-0.21.2-r2.ebuild | 7 ++++++-
 media-gfx/freecad/freecad-9999.ebuild      | 7 ++++++-
 4 files changed, 24 insertions(+), 4 deletions(-)