Bug 87334

Summary:	media-plugins/bmp-scrobbler ebuild with IUSE="debug"
Product:	Gentoo Linux	Reporter:	Tom Samstag <gentoo>
Component:	New packages	Assignee:	Tony Vroon (RETIRED) <chainsaw>
Status:	RESOLVED FIXED
Severity:	minor	CC:	sound
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Updated Ebuild for bmp-scrobbler

Description Tom Samstag 2005-03-30 14:14:43 UTC

The media-plugins/bmp-scrobbler package hardcoded -DDEBUG=1 and -DMETA_DEBUG=1. This updated ebuild adds IUSE="debug" and if built without +debug, disables printing debug messages.

I also added ~amd64 to the keywords, obsoleting bug #86394.

BTW, I'm not sure about giving this a revision 1, but that's up to the admin who puts this into cvs.

Reproducible: Always
Steps to Reproduce:
1. Run beep-media-player with the bmp-scrobbler plugin enabled
Actual Results:  
Debug messages printed to terminal

Expected Results:  
No output to standard out/error

Comment 1 Tom Samstag 2005-03-30 14:15:30 UTC

Created attachment 54884 [details]
Updated Ebuild for bmp-scrobbler

Comment 2 Tom Samstag 2005-03-30 14:18:23 UTC

*** Bug 87336 has been marked as a duplicate of this bug. ***

Comment 3 Tony Vroon (RETIRED) gentoo-dev

2005-04-01 13:36:02 UTC

I have rewritten your USE logic as follows:

        if ! useq debug; then
                sed -i 's:-DDEBUG=1:-DDEBUG=0:' Makefile.*
                sed -i 's:-DMETA_DEBUG=1:-DMETA_DEBUG=0:' Makefile.*
                sed -i 's:^[ \t]*printf::' scrobbler.c
        fi

This is silent and only checks the state of USE-flag once.

Comment 4 Tony Vroon (RETIRED) gentoo-dev

2005-04-01 13:38:06 UTC

This is in portage as 0.3.6-r1, please give the new ebuild two hours to propagate before you sync your portage tree.

Thank you for your report.