Bug 873139 – dev-vcs/git-big-picture-1.2.1 fails tests with sys-apps/grep-3.8

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-09-27 07:04:34 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-vcs/git-big-picture-1.2.1 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-09-27 07:04:36 UTC]

Created attachment 814315 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-09-27 07:04:38 UTC]

Error(s) that match a know pattern:


+    ls: cannot access '/var/tmp/portage/dev-vcs/git-big-picture-1.2.1/temp/cramtests-a8le7ene/tmp/git-big-picture-s7fu95mw.svg': No such file or directory
-    ls: .*/.+/git-big-picture.*.svg.*No such file or directory (re)

[Comment 3 Larry the Git Cow 2022-09-27 20:22:37 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f085fd48f029a9287111b687c9dc50047c0108cc

commit f085fd48f029a9287111b687c9dc50047c0108cc
Author:     Sebastian Pipping <[e-mail]>
AuthorDate: 2022-09-27 20:21:18 +0000
Commit:     Sebastian Pipping <[e-mail]>
CommitDate: 2022-09-27 20:21:18 +0000

    dev-vcs/git-big-picture: 1.2.2 + EAPI 8 + fix tests for grep 3.8
    
    Closes: https://bugs.gentoo.org/873139
    Signed-off-by: Sebastian Pipping <[e-mail]>

 dev-vcs/git-big-picture/Manifest                   |  1 +
 .../git-big-picture/git-big-picture-1.2.2.ebuild   | 40 ++++++++++++++++++++++
 2 files changed, 41 insertions(+)

[Comment 4 Sebastian Pipping 2022-09-27 20:23:41 UTC]

Fixed upstream at https://github.com/git-big-picture/git-big-picture/pull/233