Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 872536

Summary: sys-apps/rng-tools-6.15 - rngd_jitter.c: error: invalid use of undefined type struct jent_notime_ctx
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Göktürk Yüksek <gokturk>
Status: RESOLVED FIXED    
Severity: normal CC: base-system, dliana, kernelpanic, maracay, sam, tsjk
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/nhorman/rng-tools/issues/188
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tar.bz2
logs.tar.bz2
sys-apps:rng-tools-6.15:20220922-201927.log
temp.tar.bz2
ebuild patch
fixed patch

Description Toralf Förster gentoo-dev 2022-09-23 15:42:27 UTC
x86_64-pc-linux-gnu-ar cru librngd.a fips.o 
x86_64-pc-linux-gnu-ranlib librngd.a
x86_64-pc-linux-gnu-gcc  -pipe -march=native -fno-diagnostics-color -O2  -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -o rngtest stats.o rngtest.o librngd.a -ljitterentropy 
rngd_jitter.c: In function rngd_notime_start:
rngd_jitter.c:56:45: error: invalid use of undefined type struct jent_notime_ctx
   56 |         ret = -pthread_attr_init(&thread_ctx->notime_pthread_attr);
      |                                             ^~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib_systemd-j4-20220922-130032

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-12.2.0 *
clang/llvm (if any):
Python 3.10.7
Available Rust versions:
  [1]   rust-bin-1.63.0 *
The following VMs are available for generation-2:
*)	Eclipse Temurin JRE 17.0.4.1_p1 [openjdk-jre-bin-17]
Available Java Virtual Machines:
  [1]   openjdk-jre-bin-17  system-vm

php cli (if any):
GNU Make 4.3

  HEAD of ::gentoo
commit d50b557eca37112112016e1b485bfc2c4ab00a9b
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Thu Sep 22 19:16:46 2022 +0000

    2022-09-22 19:16:46 UTC

emerge -qpvO sys-apps/rng-tools
[ebuild  N    ] sys-apps/rng-tools-6.15  USE="jitterentropy nistbeacon -pkcs11 -rtlsdr (-selinux)"
Comment 1 Toralf Förster gentoo-dev 2022-09-23 15:42:28 UTC
Created attachment 813823 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2022-09-23 15:42:30 UTC
Created attachment 813826 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2022-09-23 15:42:31 UTC
Created attachment 813829 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2022-09-23 15:42:33 UTC
Created attachment 813832 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2022-09-23 15:42:34 UTC
Created attachment 813835 [details]
logs.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2022-09-23 15:42:35 UTC
Created attachment 813838 [details]
sys-apps:rng-tools-6.15:20220922-201927.log
Comment 7 Toralf Förster gentoo-dev 2022-09-23 15:42:36 UTC
Created attachment 813841 [details]
temp.tar.bz2
Comment 8 Michelangelo Scopelliti 2022-10-05 10:06:09 UTC
the error is caused by jitterentropy-3.4*. rng-tools builds OK with jitterentropy-3.3*
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-05 10:08:42 UTC
(In reply to Michelangelo Scopelliti from comment #8)
> the error is caused by jitterentropy-3.4*. rng-tools builds OK with
> jitterentropy-3.3*

Thanks. I think we might need https://github.com/nhorman/rng-tools/commit/57be6d4c90e78ea9ad036a3a6e9b09822ed4d219.
Comment 10 Michelangelo Scopelliti 2022-12-15 09:43:26 UTC
(In reply to Sam James from comment #9)
> (In reply to Michelangelo Scopelliti from comment #8)
> > the error is caused by jitterentropy-3.4*. rng-tools builds OK with
> > jitterentropy-3.3*
> 
> Thanks. I think we might need
> https://github.com/nhorman/rng-tools/commit/
> 57be6d4c90e78ea9ad036a3a6e9b09822ed4d219.

I can confirm it builds fine against jitterentropy-3.4* with 57be6d4c90e78ea9ad036a3a6e9b09822ed4d219, but it is not possible to apply such patch alone; I downloaded the tree up to such pull request (or, to be exact, I used commit 6dcc9ec2500a25a0bb5d2397db557b73e3f48c37, "Merge pull request #180 from nefigtut/master") and it seems to work. I will attach my ebuild patch.
Comment 11 Michelangelo Scopelliti 2022-12-15 09:46:04 UTC
Created attachment 842791 [details, diff]
ebuild patch
Comment 12 Michelangelo Scopelliti 2022-12-15 15:36:55 UTC
Created attachment 842895 [details, diff]
fixed patch

There is also a new dependency -- dev-libs/jansson
Comment 13 Tamas Jantvik 2023-01-10 09:55:50 UTC
I hit this during a world rebuild when migrating to new hardware.
The patch seems to make the package build with the newer jitterentropy.
Comment 14 Tamas Jantvik 2023-01-10 09:56:51 UTC
And, I mean the ebuild-patch.
Comment 15 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-10 09:59:39 UTC
(In reply to Tamas Jantvik from comment #13)
> I hit this during a world rebuild when migrating to new hardware.
> The patch seems to make the package build with the newer jitterentropy.

I didn't really want to apply a snapshot and I was hoping upstream would make a new release but they haven't yet. I'll file a bug asking.
Comment 16 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-10 10:00:57 UTC
(In reply to Sam James from comment #15)
> (In reply to Tamas Jantvik from comment #13)
> > I hit this during a world rebuild when migrating to new hardware.
> > The patch seems to make the package build with the newer jitterentropy.
> 
> I didn't really want to apply a snapshot and I was hoping upstream would
> make a new release but they haven't yet. I'll file a bug asking.

https://github.com/nhorman/rng-tools/issues/188
Comment 17 Tamas Jantvik 2023-01-10 10:27:15 UTC
Yeah. That's great. In the meanwhile people can still apply the ebuild patch found here, or just downgrade app-crypt/jitterentropy.
Comment 18 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-11 09:19:27 UTC
New version added to Gentoo (Bugzilla was down at the time).