Summary: | app-arch/zstd: cmake config file is unavailable | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | emacsray |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | ionen, lockalsash |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020403 | ||
See Also: | https://github.com/facebook/zstd/issues/3271 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 873526 |
Description
emacsray
2022-09-21 20:41:57 UTC
The problem is CMake is not an official build system for zstd (nor is meson), so I'm reluctant to use it. Other distros may not be using it either (at last check, some went *back* to the makefiles after the "time/benchmark scandal": https://www.phoronix.com/news/Arch-Linux-Bizarre-Zstd (even though it was harmless in the end)). I suggest LLVM falls back to pkg_check_modules given the config files' existence can't be assumed. fwiw pcsx2 uses the cmake files too, but I too had mixed feelings about this, so I never opened an issue here and made it use alias_library(Zstd::Zstd PkgConfig::zstd) for now. Pretty sure many distros skip this file as well so I find it amazing it's being relied on, albeit in pcsx2's case they bundle zstd and use it via cmake themselves making the whole thing a bit awkward. sci-libs/miopen-6.0.2 also wants zstdConfig.cmake, zstd-config.cmake or Findzstd.cmake (note: in lowercase) as optional dependency. |