Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 870625

Summary: mail-filter/mailfilter: build failure with Clang 15 (error: a function definition without a prototype is deprecated in all versions of C [-Werror=strict-prototypes])
Product: Gentoo Linux Reporter: Holger Hoffstätte <holger>
Component: Current packagesAssignee: Holger Hoffstätte <holger>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/nondeterministic/mailfilter/pull/7
See Also: https://github.com/gentoo/gentoo/pull/27301
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 870412    

Description Holger Hoffstätte 2022-09-17 08:56:08 UTC
Building mailfilter with clang-15 and -Werror=strict-prototypes results in:

clang -DHAVE_CONFIG_H -I. -I..  -I/usr/local/include -I. -I../include -I.. -DLOCALEDIR=\"/usr/local/share/locale\" -I../intl -I.. -I../include -I.   -pipe -Werror=strict-prototypes -march=native -O2  -MT md5c.o -MD -MP -MF .deps/md5c.Tpo -c -o md5c.o md5c.c
md5c.c:97:6: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
void MD5Init (context)
     ^
md5c.c:113:6: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
void MD5Update (context, input, inputLen)
     ^
md5c.c:155:6: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
void MD5Final (digest, context)
     ^
md5c.c:183:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
static void MD5Transform (state, block)
            ^
md5c.c:183:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
md5c.c:275:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
static void Encode (output, input, len)
            ^
md5c.c:275:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
md5c.c:293:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
static void Decode (output, input, len)
            ^
md5c.c:293:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
md5c.c:308:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
static void MD5_memcpy (output, input, len)
            ^
md5c.c:308:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
md5c.c:321:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
static void MD5_memset (output, value, len)
            ^
md5c.c:321:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
13 errors generated.


Reproducible: Always




Patch has already been submitted upstream (see $URL), but upstream releases are rare.
Comment 1 Larry the Git Cow gentoo-dev 2022-09-17 18:24:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88b87a76b60d50f6bd753ed5825e140ddd4bab20

commit 88b87a76b60d50f6bd753ed5825e140ddd4bab20
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2022-09-17 09:00:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-17 18:23:38 +0000

    mail-filter/mailfilter: fix build with -Werror=strict-prototypes (Clang 15+)
    
    Also fix configure bashisms as reported in:
    https://github.com/gentoo/gentoo/pull/27134
    
    Closes: https://bugs.gentoo.org/870625
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/27301
    Signed-off-by: Sam James <sam@gentoo.org>

 mail-filter/mailfilter/files/0.8.9-bashisms.patch  |  26 ++++
 .../mailfilter/files/0.8.9-prototypes.patch        | 132 +++++++++++++++++++++
 mail-filter/mailfilter/mailfilter-0.8.9.ebuild     |   5 +
 3 files changed, 163 insertions(+)