| Summary: | dev-libs/xmlrpc-c needs patches to make use of PKG_CONFIG | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Mark Yacoub <markyacoub> |
| Component: | Current packages | Assignee: | Sergey Popov <pinkbyte> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mattst88, sam |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | dev-libs/xmlrpc-c patch | ||
Thanks! You mentioned they're upstream -- could you either pop links here or in the patch you attached to the respective commits/submission/bugs? Hi Sam, thanks for the fast reponse. Here are the 2 patches I depended on: [1] sourceforge[dot]net/p/xmlrpc-c/code/3151 [2] sourceforge[dot]net/p/xmlrpc-c/code/3152 I modified them a little bit to make it work for the current version in the gentoo package. Hi Sam, I'm following up on this pull request, if there is anything you need on my end to help get it merged. Thanks! The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9b83345ff0a30dd9625d2220f00867c710705d8 commit c9b83345ff0a30dd9625d2220f00867c710705d8 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-09-23 01:07:09 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-09-23 01:18:24 +0000 dev-libs/xmlrpc-c: use pkg-config to find deps Closes: https://bugs.gentoo.org/870253 Thanks-to: Mark Yacoub <markyacoub@chromium.org> Signed-off-by: Sam James <sam@gentoo.org> .../xmlrpc-c-1.51.06-pkg-config-libxml2.patch | 225 +++++++++++++++++++++ .../xmlrpc-c-1.51.06-pkg-config-openssl.patch | 46 +++++ dev-libs/xmlrpc-c/xmlrpc-c-1.51.06-r3.ebuild | 88 ++++++++ dev-libs/xmlrpc-c/xmlrpc-c-1.54.05-r1.ebuild | 88 ++++++++ 4 files changed, 447 insertions(+) (In reply to Mark Yacoub from comment #3) > Hi Sam, I'm following up on this pull request, if there is anything you need > on my end to help get it merged. Thanks! Thanks for the ping - sorry, it'd fallen off my list! I made some touchups like: - adding the toolchain-funcs.eclass inherit needed for tc-export - renamed the patches and gave the references you provided at the top of them - used PATCHES as an array instead of eapply - added pkg-config to BDEPEND - added the patches to the latest version too 'pkgcheck scan' could help to find the missing inherits for future use. If possible, could you use 'git format-patch' to generate patches to submit for future bugs? It's not a problem, it's just nicer to ensure proper credit and such. Then it's easy to include 'Signed-off-by' within too. Applied & thanks! |
Created attachment 805378 [details, diff] dev-libs/xmlrpc-c patch xmlrpc upstream fixed a bug of making use of PKG_CONFIG environment variable, which also invokes libxml-2.0. I'm having some trouble pushing a PR, so I'm adding here a patch that backports the upstream patches to the gentoo package. Thank you!