Bug 870013 – app-portage/kuroo: 1.2.2 version bump request

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description A Schenck 2022-09-13 18:21:39 UTC]

Made a new release for kuroo. The changes aren't huge, mostly code quality and some convenience things:
Better modals (centered on the main application)
Port atom parsing regex directly from portage code
Horizontal scroll bars in queue view
Deprecation and clazy warnings
Update QT, KF, and ECM versions
Add KCrash::initialize in main
Reimplement CachePortageJob to work with Manifest2 format (had been disabled for years) for calculating the download size

Reproducible: Always

Steps to Reproduce:
N/A



Also attached an updated kuroo-9999 ebuild

[Comment 1 A Schenck 2022-09-13 18:22:59 UTC]

Created attachment 805000 [details]
New ebuild for version 1.2.2

[Comment 2 A Schenck 2022-09-13 18:23:16 UTC]

Created attachment 805003 [details]
New live ebuild

[Comment 3 Andreas Sturmlechner 2022-09-13 18:25:40 UTC]

Thanks for your work. In general please attach unified diffs so changes can be easily reviewed.

[Comment 4 A Schenck 2022-09-13 19:53:41 UTC]

Created attachment 805024 [details, diff]
kuroo-9999.ebuild diff

diff between previous kuroo-9999.ebuild and new

[Comment 5 A Schenck 2022-09-13 19:55:47 UTC]

Created attachment 805027 [details, diff]
diff between current 1.2.1 ebuild in portage and new 1.2.2 eubild

[Comment 6 Andreas Sturmlechner 2022-09-13 20:19:32 UTC]

Please note that BDEPEND=kde-frameworks/extra-cmake-modules is already provided for by ecm.eclass.

Quoting myself from bug 811693
> I notice that you bump your upstream minimum version requirements to align with
> up to date Gentoo stable versions. I'm not stopping you, but this is by no
> means necessary (and other projects are much more conservative and only update
> those versions as necessary by the code).
If you want to go a step further to make this minimum version meaningful by making your code build without deprecations, you could add to CMakeLists.txt:

> include(ECMDeprecationSettings)
> 
> ecm_set_disabled_deprecation_versions(
>     QT 5.15.2
>     KF 5.98.0
>     )
That would put you ahead of the curve for porting to Qt6/KF6 even while still building against Qt5/KF5.

[Comment 7 Larry the Git Cow 2022-09-13 20:54:13 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ec49fec2c38d290fbcdf07ecb4cec1cb893745b

commit 1ec49fec2c38d290fbcdf07ecb4cec1cb893745b
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2022-09-13 20:31:41 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2022-09-13 20:53:48 +0000

    app-portage/kuroo: add 1.2.2
    
    Thanks-to: Andrew Schenck <[e-mail]>
    Closes: https://bugs.gentoo.org/870013
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 app-portage/kuroo/Manifest           |  1 +
 app-portage/kuroo/kuroo-1.2.2.ebuild | 48 ++++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe7f1701bad5a486226c1d318b6b327d52380bd2

commit fe7f1701bad5a486226c1d318b6b327d52380bd2
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2022-09-13 19:55:39 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2022-09-13 20:53:48 +0000

    app-portage/kuroo: Add new dependency, drop duplicate BDEPEND
    
    BDEPEND is provided by em.eclass.
    
    Thanks-to: Andrew Schenck <[e-mail]>
    Bug: https://bugs.gentoo.org/870013
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 app-portage/kuroo/kuroo-9999.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)