Bug 869770 – dev-python/python-bugzilla-3.2.0-r1 fails tests

• Product: Gentoo Linux
• Status: RESOLVED WORKSFORME

[Description Agostino Sarubbo 2022-09-11 17:29:45 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/python-bugzilla-3.2.0-r1 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-09-11 17:29:47 UTC]

Created attachment 804739 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-09-11 17:29:49 UTC]

Error(s) that match a know pattern:


E       UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 367: ordinal not in range(128)
E       UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 5306: ordinal not in range(128)
FAILED tests/test_api_attachments.py::test_api_attachments - UnicodeDecodeErr...
FAILED tests/test_api_bug.py::test_bug_apis - UnicodeDecodeError: 'ascii' cod...
FAILED tests/test_cli_attach.py::test_attach_get - UnicodeDecodeError: 'ascii...
 "bugzilla: error: Bug IDs '['123456']' not used for getting attachments\n")

[Comment 3 Eli Schwartz 2024-03-05 05:12:06 UTC]

Package doesn't compile anything, so how could it be because of LTO...

[Comment 4 Eli Schwartz 2024-03-05 20:09:00 UTC]

As far as I can tell this works fine without any fiddling.